Fix: Android crash (NPE) on any BLE error — all onError callbacks pass null as the promise rejection code#1335
Open
nas887 wants to merge 1 commit intodotintent:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every onError callback in BlePlxModule.java calls:
safePromise.reject(null, errorConverter.toJs(error));The code parameter of PromiseImpl.reject is annotated @nonnull in the React Native bridge. Passing null bypasses the JS
error handler entirely and crashes the Android process with:
This means any BLE error on Android is a fatal crash, not a catchable JS exception.
Fix: pass String.valueOf(error.errorCode.code) so the BleErrorCode integer (e.g. 401 for CharacteristicWriteFailed) is used as the rejection code, matching what the JS layer expects.