Skip to content

Fix: Android crash (NPE) on any BLE error — all onError callbacks pass null as the promise rejection code #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nas887 wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −17
Open

Fix: Android crash (NPE) on any BLE error — all onError callbacks pass null as the promise rejection code #1335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions android/src/main/java/com/bleplx/BlePlxModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public void onSuccess(Void data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand All @@ -188,7 +188,7 @@ public void onSuccess(Void data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand Down Expand Up @@ -319,7 +319,7 @@ public void onSuccess(Device data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand All @@ -339,7 +339,7 @@ public void onSuccess(Device data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand All @@ -359,7 +359,7 @@ public void onSuccess(Device data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand Down Expand Up @@ -423,7 +423,7 @@ public void onEvent(ConnectionState connectionState) {
new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand All @@ -443,7 +443,7 @@ public void onSuccess(Device data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand Down Expand Up @@ -484,7 +484,7 @@ public void onSuccess(Device data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand Down Expand Up @@ -628,7 +628,7 @@ public void onSuccess(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand All @@ -655,7 +655,7 @@ public void onSuccess(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand All @@ -681,7 +681,7 @@ public void onSuccess(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
});
}
Expand All @@ -707,7 +707,7 @@ public void onSuccess(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand All @@ -733,7 +733,7 @@ public void onSuccess(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand All @@ -758,7 +758,7 @@ public void onSuccess(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand Down Expand Up @@ -789,7 +789,7 @@ public void onEvent(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand Down Expand Up @@ -819,7 +819,7 @@ public void onEvent(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));
}
}
);
Expand Down Expand Up @@ -849,7 +849,7 @@ public void onEvent(Characteristic data) {
}, new OnErrorCallback() {
@Override
public void onError(BleError error) {
safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
safePromise.reject(String.valueOf(error.errorCode.code), errorConverter.toJs(error));safePromise.reject(getErrorCode(error), errorConverter.toJs(error));
}
}
);
Expand Down