Merging internal commits for release/8.0 #120718
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d v4 Updated prepare-signed-artifacts.yml - use microbuild v4 ---- #### AI description (iteration 1) #### PR Classification This pull request updates a CI pipeline configuration by upgrading the MicroBuildSigningPlugin version. #### PR Summary This pull request modifies the pipeline YAML to use MicroBuildSigningPlugin version 4 instead of version 2 and adds a new parameter for the connected PME service. - `eng/pipelines/official/jobs/prepare-signed-artifacts.yml`: Updated the task version from `MicroBuildSigningPlugin@2` to `MicroBuildSigningPlugin@4` and added the `ConnectedPMEServiceName` parameter with a specified service ID. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…-merge-8.0-2025-10-14-1142
There was a problem hiding this comment.
Pull Request Overview
This PR adds early failure detection for SMTP connections that require SSL/TLS when the server doesn't support EHLO. The change prevents attempting HELO commands when SSL is enabled and EHLO has failed, since HELO cannot advertise STARTTLS capability.
- Adds validation to fail early when SSL is required but server only supports HELO
- Improves error handling by throwing a clear exception about STARTTLS not being supported
PranavSenthilnathan
approved these changes
Oct 14, 2025
PranavSenthilnathan
merged commit 46d412f
into
dotnet:release/8.0
110 of 116 checks passed
This was referenced Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.