Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #47898

Merged
merged 8 commits into from
Mar 29, 2025
Merged

[main] Update dependencies from dotnet/runtime #47898

merged 8 commits into from
Mar 29, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 26, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-preview.3.25155.1 to 10.0.0-preview.4.25176.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 10.0.0-preview.3.25155.1 to 10.0.0-preview.4.25176.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
8860e3d 
…0325.7

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.4.25174.9 -> To Version 10.0.0-preview.4.25175.7
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Mar 26, 2025
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

This was referenced Mar 26, 2025
Open
Open
@ViktorHofer
Copy link
Member

src\aspnetcore\src\Logging.AzureAppServices\src\Microsoft.Extensions.Logging.AzureAppServices.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: System.ValueTuple from 4.6.1 to 4.5.0. Reference the package directly from the project to select a different version.
Microsoft.Extensions.Logging.AzureAppServices -> Microsoft.Extensions.Logging 10.0.0-ci -> System.ValueTuple (>= 4.6.1)
Microsoft.Extensions.Logging.AzureAppServices -> System.ValueTuple (>= 4.5.0)

@carlossanlop

@carlossanlop
Copy link
Member

@ViktorHofer I wonder why my dotnet/dotnet PR didn't hit this: https://github.com/dotnet/dotnet/pull/155/checks?check_run_id=39337204580

@akoeplinger
Copy link
Member

We're also seeing this in dotnet/aspnetcore#61011. Do we need changes like you did in dotnet/aspnetcore#60481?

@carlossanlop
Copy link
Member

Yes, I'm about to send a PR to aspnetcore. Give me a few mins @akoeplinger .

@carlossanlop
Copy link
Member

Maybe I can push the commits directly to that deps flow, saves time.

@carlossanlop carlossanlop added the Blocked Issue is blocked on an external dependency label Mar 26, 2025
@carlossanlop carlossanlop self-assigned this Mar 26, 2025
@build-analysis build-analysis bot mentioned this pull request Mar 27, 2025
Open
dotnet-maestro bot and others added 2 commits March 27, 2025 05:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
e68f5d3 
…0326.7

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.4.25174.9 -> To Version 10.0.0-preview.4.25176.7

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-preview.3.25155.1 -> To Version 10.0.0-preview.4.25175.2 (parent: Microsoft.NETCore.App.Runtime.win-x64
@akoeplinger
Remove patches
e630153
@akoeplinger akoeplinger requested review from a team as code owners March 27, 2025 11:24
@build-analysis build-analysis bot mentioned this pull request Mar 27, 2025
Open
3 tasks
@carlossanlop
Copy link
Member

We're also seeing this in dotnet/aspnetcore#61011. Do we need changes like you did in dotnet/aspnetcore#60481?

I unblocked the aspnetcore PR: dotnet/aspnetcore#61011

But it now has some other blocking failures (unrelated to mine).

@jkoritzinsky
Copy link
Member

@vcsjones @bartonjs the failures in source-build look related to some OpenSSL3 work.

@jkoritzinsky jkoritzinsky mentioned this pull request Mar 27, 2025
Open
@am11
Copy link
Member

am11 commented Mar 27, 2025

@vcsjones @bartonjs the failures in source-build look related to some OpenSSL3 work.

It was fixed by dotnet/runtime#113965.

@vcsjones
Copy link
Member

vcsjones commented Mar 27, 2025 •
edited
Loading

@jkoritzinsky

 /__w/1/vmr/src/runtime/src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_ml_dsa.c:117:9: error: call to undeclared function 'EVP_PKEY_sign_message_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        117 |     if (EVP_PKEY_sign_message_init(ctx, NULL, contextParams) <= 0)
            |         ^
      /__w/1/vmr/src/runtime/src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_ml_dsa.c:117:9: note: did you mean 'EVP_PKEY_sign_init'?
      /usr/include/openssl/evp.h:1913:5: note: 'EVP_PKEY_sign_init' declared here
       1913 | int EVP_PKEY_sign_init(EVP_PKEY_CTX *ctx);
            |     ^
      [  8%] Building C object /__w/1/vmr/src/runtime/artifacts/obj/external/libunwind/CMakeFiles/libunwind.dir/__w/1/vmr/src/runtime/src/native/external/libunwind/src/x86_64/Lglobal.c.o
      [  8%] Building C object libs-native/System.Security.Cryptography.Native/CMakeFiles/objlib.dir/pal_hmac.c.o
      /__w/1/vmr/src/runtime/src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_ml_dsa.c:197:9: error: call to undeclared function 'EVP_PKEY_verify_message_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        197 |     if (EVP_PKEY_verify_message_init(ctx, NULL, contextParams) <= 0)
            |         ^
      /__w/1/vmr/src/runtime/src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_ml_dsa.c:197:9: note: did you mean 'EVP_PKEY_verify_recover_init'?
      /usr/include/openssl/evp.h:1923:5: note: 'EVP_PKEY_verify_recover_init' declared here
       1923 | int EVP_PKEY_verify_recover_init(EVP_PKEY_CTX *ctx);
            |     ^
      2 errors generated.

Those were fixed this morning afternoon at dotnet/runtime#113965.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
19fece7 
…0327.9

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.4.25174.9 -> To Version 10.0.0-preview.4.25177.9

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-preview.3.25155.1 -> To Version 10.0.0-preview.4.25176.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@carlossanlop
Copy link
Member

dotnet/aspnetcore#61011 was merged in aspnetcore and we have an open PR to flow it here: #47989

@carlossanlop carlossanlop mentioned this pull request Mar 28, 2025
Merged
@akoeplinger
Copy link
Member

@carlossanlop looks like arcade needs a change as well:

src/arcade/src/VersionTools/Microsoft.DotNet.VersionTools/Microsoft.DotNet.VersionTools.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: System.Memory from 4.6.2 to centrally defined 4.6.0. Update the centrally managed package version to a higher version. 
 Microsoft.DotNet.VersionTools -> System.Formats.Asn1 10.0.0-preview.4.25177.9 -> System.Memory (>= 4.6.2) 
 Microsoft.DotNet.VersionTools -> System.Memory (>= 4.6.0)

@carlossanlop carlossanlop mentioned this pull request Mar 28, 2025
Merged
@carlossanlop
Copy link
Member

@carlossanlop looks like arcade needs a change as well

Thanks for the ping @akoeplinger . I submitted a PR to fix this dotnet/arcade#15681 and I also pushed the same commits in my test PR for dotnet/dotnet https://github.com/dotnet/dotnet/pull/155/files

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
12499b2 
…0328.6

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-preview.4.25174.9 -> To Version 10.0.0-preview.4.25178.6
@carlossanlop
Copy link
Member

carlossanlop commented Mar 29, 2025 •
edited
Loading

I merged the arcade PR that's blocking this dotnet/arcade#15681
Now we wait for it to flow into here.

@mmitche mmitche enabled auto-merge (squash) March 29, 2025 19:37
@mmitche mmitche merged commit d945ac6 into main Mar 29, 2025
40 of 43 checks passed
@mmitche mmitche deleted the darc-main-2271196d-bbdf-4951-94f5-f19300c7ef40 branch March 29, 2025 19:37
ViktorHofer added a commit that referenced this pull request Mar 31, 2025
@ViktorHofer
Revert "[main] Update dependencies from dotnet/runtime (#47898)"
bcbdf9f 
This reverts commit d945ac6.
@ViktorHofer ViktorHofer mentioned this pull request Mar 31, 2025
Merged
@ViktorHofer
Copy link
Member

@mmitche I'm not sure how this PR got merged given the failures in the FullFramework leg (I assume the job was retried but BuildAnalysis did show as green and so the auto-merge action was triggered?) but we need to revert it. #48020

@ViktorHofer ViktorHofer mentioned this pull request Mar 31, 2025
Merged
@mmitche
Copy link
Member

mmitche commented Mar 31, 2025

Must have been because BA was green?

@mmitche
Copy link
Member

mmitche commented Mar 31, 2025

@missymessa Any insight here? BA is showing as failed in the merged commit, but auto-merge kicked in. Perhaps it showed briefly as green?

@baronfel baronfel mentioned this pull request Mar 31, 2025
Closed
@missymessa
Copy link
Member

@mmitche we have an open issue to investigate this here: dotnet/dnceng#3327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

@carlossanlop carlossanlop

Labels
Area-CodeFlow Blocked Issue is blocked on an external dependency untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ViktorHofer @carlossanlop @akoeplinger @jkoritzinsky @am11 @vcsjones @mmitche @missymessa @v-wuzhai