Skip to content

[wasm] Enable tests disabled by preloading & compression endpoint issue #48663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

[wasm] Enable tests disabled by preloading & compression endpoint issue #48663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f249d59
Enable tests
maraf Apr 23, 2025
2419e97
Merge branch 'main' into WasmEnableTests
maraf Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorWasmStaticWebAssetsIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ namespace Microsoft.NET.Sdk.BlazorWebAssembly.Tests
{
public class BlazorWasmStaticWebAssetsIntegrationTest(ITestOutputHelper log) : BlazorWasmBaselineTests(log, GenerateBaselines)
{
// [RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void StaticWebAssets_BuildMinimal_Works()
{
// Arrange
Expand Down Expand Up @@ -52,8 +51,7 @@ public void StaticWebAssets_BuildMinimal_Works()
intermediateOutputPath);
}

// [RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void StaticWebAssets_PublishMinimal_Works()
{
// Arrange
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ public void Build_Hosted_Works()
new FileInfo(Path.Combine(buildOutputDirectory, "wwwroot", "_framework", "_bin", "blazorwasm.wasm")).Should().NotExist();
}

[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[Fact]
public void Build_SatelliteAssembliesAreCopiedToBuildOutput()
{
// Arrange
Expand Down
11 changes: 4 additions & 7 deletions test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmJsModulesIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ namespace Microsoft.NET.Sdk.BlazorWebAssembly.Tests
{
public class WasmJsModulesIntegrationTests(ITestOutputHelper log) : BlazorWasmBaselineTests(log, GenerateBaselines)
{
//[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest()
{
// Arrange
Expand Down Expand Up @@ -96,8 +95,7 @@ public void JSModules_ManifestIncludesModuleTargetPaths()
new FileInfo(Path.Combine(outputPath, "wwwroot", "blazorhosted.modules.json")).Should().NotExist();
}

//[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void Publish_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest()
{
// Arrange
Expand Down Expand Up @@ -144,8 +142,7 @@ public void Publish_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJso
intermediateOutputPath);
}

//[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void JsModules_CanHaveDifferentBuildAndPublishModules()
{
// Arrange
Expand Down Expand Up @@ -217,7 +214,7 @@ static JsonElement GetLibraryInitializer(string path)
}
}

[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[Fact]
public void JsModules_CanCustomizeBlazorInitialization()
{
// Arrange
Expand Down
6 changes: 2 additions & 4 deletions test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetEndpointsIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,7 @@ public void Publish_CreatesEndpointsForAssets_BuildAndPublish_Assets()
AssertManifest(publishManifest, LoadPublishManifest());
}

//[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void Build_EndpointManifest_ContainsEndpoints()
{
// Arrange
Expand Down Expand Up @@ -463,8 +462,7 @@ public void BuildHosted_EndpointManifest_ContainsEndpoints()
VerifyEndpointsCollection(buildOutputDirectory, "blazorhosted", readFromDevManifest: true);
}

//[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
[Fact(Skip = "https://github.com/dotnet/runtime/issues/114915")]
[RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")]
public void Publish_EndpointManifestContainsEndpoints()
{
// Arrange
Expand Down