Skip to content

[wasm] Enable tests disabled by preloading & compression endpoint issue #48663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 23, 2025

@maraf maraf marked this pull request as ready for review April 24, 2025 17:28
@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 17:28
@maraf maraf requested review from a team as code owners April 24, 2025 17:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables several tests that were previously disabled due to a System.Text.Json dependency issue by replacing the [Fact(Skip = ...)] attributes with either [RequiresMSBuildVersionFact("17.12", ...)] or by removing the skip parameter. Key changes include:

  • Replacing disabled test attributes with [RequiresMSBuildVersionFact("17.12", Reason = "Needs System.Text.Json 8.0.5")] in multiple test files.
  • Enabling previously skipped tests by removing the skip parameters.
  • Removing commented-out attribute lines to clean up the code.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetEndpointsIntegrationTest.cs Re-enabled tests by replacing the disabled attributes.
test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmJsModulesIntegrationTests.cs Updated test attributes to re-enable tests; one test now uses [Fact] while others use [RequiresMSBuildVersionFact].
test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs Re-enabled a test by removing the skip parameter.
test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BlazorWasmStaticWebAssetsIntegrationTest.cs Re-enabled tests by replacing disabled attributes with [RequiresMSBuildVersionFact].
Comments suppressed due to low confidence (1)

test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmJsModulesIntegrationTests.cs:217

  • [nitpick] The test 'JsModules_CanCustomizeBlazorInitialization' is now enabled with [Fact] instead of using [RequiresMSBuildVersionFact] like its peers. Please confirm that this difference in test enabling is intentional and that the test's prerequisites are met.
[Fact]

@maraf maraf merged commit b16dd92 into dotnet:main Apr 24, 2025
39 checks passed
@maraf maraf deleted the WasmEnableTests branch April 24, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants