-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use_transaction
parameter for postgres_query()
and postgres_execute()
#310
Open
daniellietz
wants to merge
14
commits into
duckdb:main
Choose a base branch
from
daniellietz:add-transaction-param-execute
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add use_transaction
parameter for postgres_query()
and postgres_execute()
#310
daniellietz
wants to merge
14
commits into
duckdb:main
from
daniellietz:add-transaction-param-execute
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create postgres_query_use_transaction.test
I am not sure why the pipeline is failing. The failures seem independent of the changes made in this PR. I have tried to bump DuckDB to v1.2.1 in the most recent commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298
use_transaction
is an optional named parameter and set to true by default. If it is not mentioned, no behavior changes.Not allowed to be turned off in read-only mode or inside an ongoing DuckDB transaction.
When turned off explicitly, it allows to execute queries that are not encapsulated by a transaction.
This allows to run operations such as
VACUUM
on your attached postgres database and gives you more control as to whether you want to use transactions in your queries or not.Sample output: