Skip to content

Widen range of cmake_minimum_required #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Apr 3, 2025

This should be mostly a nop, but allow postgres_scanner to be explicitly compatible with newer cmake versions.

@carlopi carlopi force-pushed the fix_cmake branch 7 times, most recently from 2d855a7 to d97166a Compare April 3, 2025 12:05
@carlopi carlopi force-pushed the fix_cmake branch 5 times, most recently from 395241c to 7aa744e Compare April 3, 2025 12:38
@carlopi
Copy link
Contributor Author

carlopi commented Apr 3, 2025

This looks ready to me, unsure on the failure, probably duckdb side?

Query unexpectedly failed! (/home/runner/work/duckdb-postgres/duckdb-postgres/test/sql/storage/attach_copy_from_database.test:55)!
================================================================================
COPY FROM DATABASE s1 TO new_db;
================================================================================
INTERNAL Error: Attempted to access index 0 within vector of size 0

Stack Trace:

/home/runner/work/duckdb-postgres/duckdb-postgres/build/release/src/libduckdb.so(duckdb::Exception::ToJSON(duckdb::ExceptionType, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x68) [0x7fd34c7b23b8]
/home/runner/work/duckdb-postgres/duckdb-postgres/build/release/src/libduckdb.so(duckdb::Exception::Exception(duckdb::ExceptionType, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x28) [0x7fd34c7b2428]
/home/runner/work/duckdb-postgres/duckdb-postgres/build/release/src/libduckdb.so(duckdb::InternalException::InternalException(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)+0x15) [0x7fd34c7b5585]
./build/release//test/unittest(duckdb::InternalException::InternalException<unsigned long, unsigned long>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned long, unsigned long)+0x177) [0x5572d3311567]
/home/runner/work/duckdb-postgres/duckdb-postgres/build/release/src/libduckdb.so(+0x8ec4db) [0x7fd34bcec4db]
/home/runner/work/duckdb-postgres/duckdb-postgres/build/release/src/libduckdb.so(duckdb::BoundIndex::BoundIndex(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, duckdb::IndexConstraintType, duckdb::vector<unsigned long, true> const&, duckdb::TableIOManager&, duckdb::vector<duckdb::unique_ptr<duckdb::Expression, std::default_delete<duckdb::Expression>, true>, true> const&, duckdb::AttachedDatabase&)+0x222) [0x7fd34cac1b42]

This is against duckdb v1.2.1, unsure if solved already in v1.2-histrionicus or needs to be tracked.

@Mytherin Mytherin merged commit 98482ce into duckdb:main Apr 3, 2025
17 of 18 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Apr 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants