[23974] Better explanation for depth vs mspi behavior#1194
Merged
MiguelCompany merged 2 commits into3.4.xfrom Jan 28, 2026
Merged
[23974] Better explanation for depth vs mspi behavior#1194MiguelCompany merged 2 commits into3.4.xfrom
MiguelCompany merged 2 commits into3.4.xfrom
Conversation
Signed-off-by: Raül <raulojeda@eprosima.com>
raulojeda22
requested review from
richiprosima
and removed request for
richiprosima
13 tasks
MiguelCompany
requested changes
Jan 27, 2026
Signed-off-by: Raül <raulojeda@eprosima.com>
raulojeda22
requested review from
richiprosima
and removed request for
richiprosima
MiguelCompany
approved these changes
Jan 27, 2026
Member
|
@Mergifyio backport 3.2.x 2.14.x |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
) * Better explanation for depth vs mspi behavior Signed-off-by: Raül <raulojeda@eprosima.com> * Remove references to 3.5.0 and some tweaks to previous changes Signed-off-by: Raül <raulojeda@eprosima.com> --------- Signed-off-by: Raül <raulojeda@eprosima.com> (cherry picked from commit fc163f3)
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
) * Better explanation for depth vs mspi behavior Signed-off-by: Raül <raulojeda@eprosima.com> * Remove references to 3.5.0 and some tweaks to previous changes Signed-off-by: Raül <raulojeda@eprosima.com> --------- Signed-off-by: Raül <raulojeda@eprosima.com> (cherry picked from commit fc163f3)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a better explanation for the behavior of the effective depth when max_samples_per_instance is smaller than depth, as this throws a warning in versions prior to 3.5.0 and throws an error after it.
@Mergifyio backport 3.2.x 2.14.x
Contributor Checklist
Proversion badge has been added if the documented feature is exclusive to Fast DDS Pro.Reviewer Checklist