[24110] Fix wrong update of default locators (backport #6273)#6280
Merged
MiguelCompany merged 1 commit into3.2.xfrom Mar 10, 2026
Merged
[24110] Fix wrong update of default locators (backport #6273)#6280MiguelCompany merged 1 commit into3.2.xfrom
MiguelCompany merged 1 commit into3.2.xfrom
Conversation
11 tasks
Member
|
@Mergifyio rebase |
* Refs #24110: Regression test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Make default unicast port independent Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Review Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 74adc61)
MiguelCompany
force-pushed
the
mergify/bp/3.2.x/pr-6273
branch
from
b88df24 to
a001366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in which the
defaultLocatorListwas being wrongly updated after callingset_qos. This corner-case occurred only when the metatraffic locators are set, but the default ones are left empty (not configured) and Fast DDS automatically configures them. If in this situation the participant needs to perform mutation tries in one of their ports, the participant will not preserve the mutation tries value, and in later updates will wrongly update the locator.Additionally I have refactor the communication tests to properly apply argument
sleep_before_exec, which was being applied to the main thread rather than to the specific process.Note that in the new test the seed is being specifically set, which translates into domain 31 (randomly selected). This is required to manually set the proper ports in the XML file configuration, which are mapped to the domain 31.
@Mergifyio backport 3.4.x 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6273 done by [Mergify](https://mergify.com).