[24110] Fix wrong update of default locators#6273
Merged
MiguelCompany merged 4 commits intomasterfrom Jan 27, 2026
Merged
Conversation
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 90b169b. ❌ Job Failures
|
MiguelCompany
requested changes
Jan 26, 2026
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
166cd0b to
90b169b
Compare
MiguelCompany
approved these changes
Jan 26, 2026
Member
|
@Mergifyio backport 3.4.x 3.2.x 2.14.x |
Contributor
✅ Backports have been createdDetails
Cherry-pick of 74adc61 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Refs #24110: Regression test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Make default unicast port independent Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Review Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 74adc61)
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Refs #24110: Regression test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Make default unicast port independent Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Review Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 74adc61)
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Refs #24110: Regression test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Make default unicast port independent Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Review Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 74adc61) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp
11 tasks
11 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
Jan 28, 2026
* Fix wrong update of default locators (#6273) * Refs #24110: Regression test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Make default unicast port independent Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Review Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 74adc61) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp * Solve Conflicts Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 6, 2026
* Refs #24110: Regression test Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Make default unicast port independent Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24110: Review Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit 74adc61)
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Refs #24110: Regression test * Refs #24110: Make default unicast port independent * Refs #24110: Uncrustify * Refs #24110: Review --------- (cherry picked from commit 74adc61) Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in which the
defaultLocatorListwas being wrongly updated after callingset_qos. This corner-case occurred only when the metatraffic locators are set, but the default ones are left empty (not configured) and Fast DDS automatically configures them. If in this situation the participant needs to perform mutation tries in one of their ports, the participant will not preserve the mutation tries value, and in later updates will wrongly update the locator.Additionally I have refactor the communication tests to properly apply argument
sleep_before_exec, which was being applied to the main thread rather than to the specific process.Note that in the new test the seed is being specifically set, which translates into domain 31 (randomly selected). This is required to manually set the proper ports in the XML file configuration, which are mapped to the domain 31.
@Mergifyio backport 3.4.x 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist