Misc fixes#21
Open
ekacnet wants to merge 5 commits into
Open
Conversation
Owner
ekacnet
commented
May 10, 2026
ekacnet
commented
- Better parse custom commands used for generating files
- Fix visiting protobuf and grpc libs
- Don't rely on the order for properly populating deps or srcs of protobuf libs and grpc libs
- Don't forget to import cc_proto_library if needed
- Overall postprocess to work better with strings, load, rules
Sometime you might have multiple command that generates different files in the same group of command and previous implementation was not picking all the commands leaving some files ungenerated.
After refactoring the way we parse commands for genrule we exposed a bug in the way some relation existed in the graph we have to fix them.
…buf libs and grpc libs
* preserve load(...) lines understand loaded rule symbols * emit BUILD rules with more Bazel-like formatting, add ordered attribute printing, sorted list values * correct string formatting including triple-quoted strings * avoid emitting the same rule more than once * narrow the companion _hdrs rule behavior to cc_library rules * fixes a missing-dependency bookkeeping bug with missing.setdefault(...).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 77.39% 80.12% +2.72%
==========================================
Files 23 23
Lines 4575 5101 +526
==========================================
+ Hits 3541 4087 +546
+ Misses 1034 1014 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.