Skip to content

Misc fixes #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekacnet wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Misc fixes #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d89b58
Better parse custom commands used for generating files
ekacnet May 5, 2026
c9f63cf
Fix visiting protobuf and grpc libs
ekacnet May 5, 2026
0302f13
Don't rely on the order for properly populating deps or srcs of proto…
ekacnet May 5, 2026
a5d5eb2
Don't forget to import cc_proto_library if needed
ekacnet May 5, 2026
0105078
Overall postprocess to work better with strings, load, rules
ekacnet Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bazel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,9 @@ class BazelCCProtoLibrary(BaseBazelTarget):
def __init__(self, name: str, location: str):
super().__init__("cc_proto_library", name, location)

def getGlobalImport(self) -> str:
return 'load("@com_google_protobuf//bazel:cc_proto_library.bzl", "cc_proto_library")'

def addDep(self, dep: Union[BaseBazelTarget, BazelCCImport]):
assert isinstance(dep, BazelProtoLibrary) or isinstance(dep, BazelExternalDep)
self.deps.add(dep)
Expand Down
Loading
Loading