[DiskBBQ] avoid EsAcceptDocs bug by calling cost before building iterator #138127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly benchmarks are failing with the following error:
This happens whenever we call
EsAcceptDocs#iteratorand thenEsAcceptDocs#bitsand the underlaying structure is not a bitset.More over if you try the combination
EsAcceptDocs#bitsand thenEsAcceptDocs#iteratoryou get a different error:Therefore in order to run those two methods you need to call
EsAcceptDocs#cost. I am hacking this in this PR so we can get some nightly benchmarks data points.