Skip to content

[DiskBBQ] avoid EsAcceptDocs bug by calling cost before building iterator #138127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
+5 −1
Merged

[DiskBBQ] avoid EsAcceptDocs bug by calling cost before building iterator #138127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...n/java/org/elasticsearch/index/codec/vectors/diskbbq/next/ESNextDiskBBQVectorsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,11 @@ public CentroidIterator getCentroidIterator(
float visitRatio
) throws IOException {
final FieldEntry fieldEntry = fields.get(fieldInfo.number);
final float approximateDocsPerCentroid = approximateCost / numCentroids;
float approximateDocsPerCentroid = approximateCost / numCentroids;
if (approximateDocsPerCentroid <= 1.25) {
// TODO: we need to make this call to build the iterator, otherwise accept docs breaks all together
approximateDocsPerCentroid = acceptDocs.cost();
}
final int bitsRequired = DirectWriter.bitsRequired(numCentroids);
final long sizeLookup = directWriterSizeOnDisk(values.size(), bitsRequired);
final long fp = centroids.getFilePointer();
Expand Down