#107/pagination nav redesign #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion updates closes #122
nichgalzin
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Gonna approve this with the note that the evaluation in the useEffect dependency array may need to be refactored in the future. It seems the practice would be to separate this into two effects, but this is working and seems not to effect performance so think it's fine to leave.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #122
Closes #107
Re-styles the
PaginationNavcomponent and introduces a fix to the pagination bug reported forFavouritesPageFiles changed
components/PaginationNav/**- updated the styling of this component to match the new figma designFavouritesPage.tsx- updated theuseEffectdependency array and refactored the logic onhandlePopupRemoveto enforce a re-render of the list when deleting a popup reduces the total list to a multiple of 6 or to 0UI changes
Changes to Documentation
n/a
Tests
n/a