-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiFiScan] Fix clear 'scanning bit' and clear scanCount #11075
Conversation
`WIFI_SCANNING_BIT` may not always be cleared on timeout. Also `_scanCount` will only be cleared if there is a `_scanResult`. See: espressif#8952
👋 Hello TD-er, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results 76 files 76 suites 14m 39s ⏱️ Results for commit 49a45cc. |
Closing in favor of #11188 |
WIFI_SCANNING_BIT
may not always be cleared on timeout. Also_scanCount
will only be cleared if there is a_scanResult
.See: #8952
N.B. this is a summary of discussion with @me-no-dev
Still a draft