Generalise EtherCrabWireWrite from [u8; N] to [T; N]#360
Open
jamwaffles wants to merge 3 commits intomainfrom
Open
Generalise EtherCrabWireWrite from [u8; N] to [T; N]#360jamwaffles wants to merge 3 commits intomainfrom
EtherCrabWireWrite from [u8; N] to [T; N]#360jamwaffles wants to merge 3 commits intomainfrom
Conversation
jamwaffles
force-pushed
the
wire-write-for-arrays
branch
from
435304c to
756f3d2
Compare
This became ambiguous because the impl went from `[u8; N]` only, to `[T; N]`. This meant Rust now defaults the item to `i32`, which was causing buffer overruns in this test.
This doesn't cause any perf degredation, at least with the benchmarks in this repo. They don't really focus on ser/de performance, however, so might not be the best markers.
jamwaffles
force-pushed
the
wire-write-for-arrays
branch
from
756f3d2 to
a4f57e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348