You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Yuhta I found these issues when trying to build breeze tests in ToT. The cmake change is just a result of my MR falling behind before it was merged and the other issues turned up when using ubuntu 24.04 instead of 22.04 to build.
Yeah, I'll take care of that and also include a number of changes that are needed to build perf tests and tests for other platforms after everything was moved into the breeze subdir
Yeah, I'll take care of that and also include a number of changes that are needed to build perf tests and tests for other platforms after everything was moved into the breeze subdir
@Yuhta Should be fixed now and this PR should be ready to be merged
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ready-to-mergePR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook-github-bot
added
the
CLA Signed
Yuhta
added
the
ready-to-merge
dreveman
force-pushed
the
breeze-fixes
branch
from
No description provided.