Skip to content

Conversation

@BigLep
Copy link
Member

@BigLep BigLep commented Aug 18, 2025

Summary

  • Remove "major" release level option from release CLI since we don't have special logic for major releases and have never done a major version release
  • Add "(nv$networkVersion)" suffix to GitHub issue titles when a network upgrade version is specified
  • Minor whitespace cleanup to release template

This PR will be used to collect incremental improvements during the v1.34.0 release process as recommended in the release template.

Changes that need to be made

  • When dealing with the node and miner release, we don't list commands about cherrypicking commits across to the miner branch.
  • Document more of the changelog prep commands like build: release Lotus Node and Miner v1.34.0-rc1 #13314 (comment)
  • Document when the draft RC release gets triggered
  • Document about copy/pasting changelog back into the release itself
  • Manual release GitHub workflow should default to ["node", "miner"] so more obvious what to put in there
  • It would generally be great to see our CI be able to run faster
  • Why did releases get assigned to galargh in https://filecoinproject.slack.com/archives/C027TQMUVJN/p1757019721331769 ?
  • Document about how to handle changelog entries for new RCs
  • Final release should make sure using final releases of go-state-types, filecoin-ffi and that actors CIDs don't change.
  • Is there any guide about the kind of content to have for things like the migration section of the changelog?
  • We should update the template so that it's clear that the "before RC1" tasks need to be done even if not doing an RC
  • For network upgrades, also need to update the network name like fix: update nv27 naming #13318

Changes Made

  1. Release Script (cmd/release/main.go):

    • Removed "major" from allowed release levels (now only "minor" and "patch")
    • Updated validation logic to exclude "major" releases
    • Added network version suffix to GitHub issue titles when network upgrade is specified
  2. Release Template (documentation/misc/RELEASE_ISSUE_TEMPLATE.md):

    • Added trailing newline for consistency

🤖 Generated with Claude Code

BigLep and others added 2 commits August 18, 2025 08:48
Add newline at end of file for release template improvements tracking.
This PR will be used to collect incremental improvements during the
v1.34.0 release process as recommended in the release template.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
…issue titles

1. Remove "major" release level option since we don't have special logic
   for major releases and have never done a major version release
2. Add "(nv$networkVersion)" suffix to GitHub issue titles when a
   network upgrade version is specified

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
rjan90
rjan90 previously approved these changes Aug 18, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Aug 18, 2025
@rjan90
Copy link
Contributor

rjan90 commented Aug 18, 2025

Ah, I thought this PR was only for the release scripts improvements. But this might also encompass more findings when developing the v1.34.0 release. I will therefore dismiss my review until it goes out of draft

@rjan90 rjan90 dismissed their stale review August 18, 2025 16:06

Waiting till it is going out of draft

@BigLep BigLep mentioned this pull request Sep 16, 2025
22 tasks
@BigLep BigLep changed the title docs(release): v1.34.0 release template improvements docs(release): v1.34.0 and v1.34.1 release template improvements Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer

Development

Successfully merging this pull request may close these issues.

2 participants