Skip to content

docs(release): v1.34.0 and v1.34.1 release template improvements #13270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

docs(release): v1.34.0 and v1.34.1 release template improvements #13270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d09201
docs(release): v1.34.0 release template improvements
BigLep Aug 18, 2025
4545e1e
chore(release): remove major level option and add network version to …
BigLep Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmd/release/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func main() {
},
&cli.StringFlag{
Name: "level",
Usage: "What's the level of the release? (Options: major, minor, patch)",
Usage: "What's the level of the release? (Options: minor, patch)",
Value: "patch",
Required: true,
},
Expand Down Expand Up @@ -256,8 +256,8 @@ func main() {
}

releaseLevel := c.String("level")
if releaseLevel != "major" && releaseLevel != "minor" && releaseLevel != "patch" {
return fmt.Errorf("invalid value for the 'level' flag. Allowed values are 'major', 'minor', and 'patch'")
if releaseLevel != "minor" && releaseLevel != "patch" {
return fmt.Errorf("invalid value for the 'level' flag. Allowed values are 'minor' and 'patch'")
}

networkUpgrade := c.String("network-upgrade")
Expand Down Expand Up @@ -343,6 +343,9 @@ func main() {

// Prepare issue creation options
issueTitle := fmt.Sprintf("Lotus %s v%s Release", releaseType, releaseTag)
if networkUpgrade != "" {
issueTitle += fmt.Sprintf(" (nv%s)", networkUpgrade)
}
issueBody := issueBodyBuffer.String()

// Remove duplicate newlines before headers and list items since the templating leaves a lot extra newlines around.
Expand Down
1 change: 1 addition & 0 deletions documentation/misc/RELEASE_ISSUE_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,3 +185,4 @@ See the final release notes!
# ⁉️ Do you have questions?

Leave a comment in this ticket!

Loading