Skip to content

Conversation

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Nov 11, 2025

The original errors are here:

Firestore/core/src/api/expressions.h:46:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Firestore/core/src/api/pipeline_result.h:54:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]
Firestore/core/src/api/query_snapshot.cc:93:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
Firestore/core/src/api/query_snapshot.h:69:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
Firestore/core/src/api/realtime_pipeline_snapshot.h:71:  #endif line should be "#endif  // FIRESTORE_CORE_SRC_API_REALTIME_PIPELINE_SNAPSHOT_H_"  [build/header_guard] [5]
Firestore/core/src/core/view.cc:26:  Include the directory when naming .h files  [build/include_subdir] [4]

I'm unsure how to fix this error:

Error: Directories 'Firestore/Source/Public/FirebaseFirestore/' and 'FirebaseFirestoreInternal/FirebaseFirestore/' differ:
Files only in 'Firestore/Source/Public/FirebaseFirestore/':
- FIRPipelineBridge.h
Files only in 'FirebaseFirestoreInternal/FirebaseFirestore/':

Copying the file over seemed to break a bunch of stuff.

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@cherylEnkidu
Copy link
Contributor

I can create a PR to fix the error on C++ side. For the objective-C one, I remember @NickChittle mentioned one of the directory is auto-generated. But I don't know how to generate those.

@cherylEnkidu
Copy link
Contributor

Actually, I am going to change on your branch to avoid so much rebase ...

@morganchen12
Copy link
Contributor Author

Sounds good, feel free to take over the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants