Syria language

[Ghaith-Shammout]

Before submitting this pull request, check the changes to see it's only the changes you made intentionally
If there are changes to other lines you didn't make deliberately, it's possible that your IDE made the changes with a utility like prettier.
Next time, make sure that you only add your changes by using git add -p and rather than git add Contributors.md

If you're doing something in the checklist below, put an x inside [ ] so that - [ ] becomes - [x]

• I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(＾◡＾)۶
• There are some things I'd like to improve in this tutorial. I have written them below.
• There were steps where I had errors while following this tutorial. I have written them below.

[github-actions]

Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:

• Contributors.md
• README.md
• docs/translations/README.apc.md

[rammba]

Hello @Ghaith-Shammout, thanks for the contribution and welcome to this repository 🚀

It looks like you didn't translate whole file and that sy language code doesn't exist. Can you please check my comments?

[rammba]

Which language is this exactly?
Sorry if I'm missing something, but it looks like there is no official Syrian language, or at least I didn't found it by quick googling. Wikipedia article says that there are few languages spoken in Syria.

[rammba]

Looks like you didn't translate whole official readme file. Few sections are missing and non of the images are here.

[rammba]

New languages often goes at the end of the list. I think we will sort the list at some moment.

[Ghaith-Shammout]

Hi @rammba and thanks for your help on this PR.
I updated the branch based on your feedback.

When it comes to the language, it should be Arabic with Syria dialect. I missed to type Arabic because I was very exited to contribute to this repo.

Kindly, let me know if there anything that need further attention

[rammba]

Hello @Ghaith-Shammout, thanks for clarification.
If it's Arabic language with Syrian dialect, and not some other eg. Levantine Arabic, can you please rename file to README.ar-sy.md then?
Sorry if I'm picky about this, but we already have an issue (#105711) to properly name existing languages, so it's good to have correct names in the new languages.

[Ghaith-Shammout]

Not at all, I like getting feedback 😊
What if I want this contribution to be in Levantine Arabic, what should I call the README file, what additional step do I need to take?

[rammba]

Hello @Ghaith-Shammout, thanks for the interest in the proper naming of the file.
I'm not familiar with variations of Arabic languages at all, but, in theory, it's possible to add both Syrian Arabic and Levantine Arabic, if they are not the same.
As mentioned in #105711, we want to name files with proper language code based on ISO 639 list. So, if you want to use Levantine, use apc code, or ar-sy for Syrian Arabic.

[Roshanjossey]

Hi @Ghaith-Shammout do you understand the content in https://github.com/firstcontributions/first-contributions/blob/main/docs/translations/README.ar.md ?

[Ghaith-Shammout]

Yes, I do understand the content in that README file @Roshanjossey.
I just want to contribute to this repo by adding the Levantine Arabic.

[rammba]

Hello @Ghaith-Shammout, thanks for the clarification about used language.
Can you maybe add yourself to the CONTRIBUTING.md. Doing that, everyone can find you and ask for help about future Levantine Arabic translations.

[rammba]

Change this line to use Levantine Arabic and correct README file name.

[rammba]

Hello @Roshanjossey, you can merge new language, Levantine Arabic 🚀

[Ghaith-Shammout]

Thank you for yours support 🤍

[Roshanjossey]

I asked my Syrian friends too. They can also understand https://github.com/firstcontributions/first-contributions/blob/main/docs/translations/README.ar.md. In this case, I think it's best not to add this translation.

[rammba]

Hello @Roshanjossey, even though they understand, maybe this language has varieties with the original Arabic.
I'm not familiar with Arabic, but Balkan languages (Serbian, Croatian, Bosnian, Montenegrin) are also a bit similar, and we have all of them listed. There are differences of course, but I think people can grasp the gist of the content in these languages.