Skip to content

fix #5153: When logging out the homepage is fetched twice. #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix #5153: When logging out the homepage is fetched twice. #5160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02310b2
fix #5153: When logging out the homepage is fetched twice.
BertKoor May 26, 2025
f9ced6c
fix #5153 updated: chose whether to respond with empty response or re…
BertKoor Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/Http/RequestHandlers/Logout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
use Psr\Http\Server\RequestHandlerInterface;

use function redirect;
use function response;
use function route;

/**
Expand All @@ -52,6 +53,12 @@ public function handle(ServerRequestInterface $request): ResponseInterface
FlashMessages::addMessage(I18N::translate('You have signed out.'));
}

return redirect(route(HomePage::class));
if ($request->getHeaderLine('X-Requested-With') !== '') {
// Ajax request - send empty response
return response();
} else {
// Form submission - redirect to home page
return redirect(route(HomePage::class));
}
}
}
Loading