Skip to content

[rfw] Add an example of using JavaScript with RFW #9110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

moluopro
Copy link

@moluopro moluopro commented Apr 18, 2025

I have added an example using JavaScript with RFW. This new example essentially replicates the functionality of the previous wasm example. Since the wasm package has been marked as discontinued and can no longer run directly on certain platforms, I included this new example as a replacement.

The new example is compatible with all Flutter platforms.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@moluopro
Copy link
Author

moluopro commented May 8, 2025

I believe the wasm case should be removed, as it often fails to run in the new version of Flutter. Since this is a significant change, I would like to get the reviewer's opinion. @stuartmorgan-g

@stuartmorgan-g
Copy link
Contributor

@moluopro Please do not comment in completely unrelated PRs to request reviews. The proper escalation path, as explained in our contributor documentation, is to contact the reviewer via Discord.

I would like to get the reviewer's opinion. @stuartmorgan-g

The reviewer is @Hixie, the code owner for this package, not me.

@moluopro
Copy link
Author

moluopro commented May 8, 2025

@moluopro Please do not comment in completely unrelated PRs to request reviews. The proper escalation path, as explained in our contributor documentation, is to contact the reviewer via Discord.

I would like to get the reviewer's opinion. @stuartmorgan-g

The reviewer is @Hixie, the code owner for this package, not me.

I’m really sorry! I saw in that PR that, since Hixie didn’t respond, he reached out to you, so I thought I could do the same. I’m not very familiar with this process, as this is my first time submitting a PR for this library. I apologize again for the inconvenience caused.

@Hixie
Copy link
Contributor

Hixie commented May 8, 2025

It's an interesting example, but I don't really understand the use case for using RFW with a JS backend. If you're using JS, why not just send HTML?

@moluopro
Copy link
Author

moluopro commented May 9, 2025

The main reason I want to submit this change is that the WASM example is not running. I believe it's important to ensure that the official examples work on all Flutter platforms.

Secondly, JavaScript is a popular language with many users, so I chose it as the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants