Skip to content

Add ASLZ Control Extension#78

Merged
defunctzombie merged 2 commits intofoxglove:mainfrom
XENONFFM:main
May 1, 2026
Merged

Add ASLZ Control Extension#78
defunctzombie merged 2 commits intofoxglove:mainfrom
XENONFFM:main

Conversation

@XENONFFM
Copy link
Copy Markdown
Contributor

Changelog

New Extension: ASLZ Control Extension - Foxglove panels for remote control using a gampad/joystick/keyboard.
Repository & Documentation

@msadowski
Copy link
Copy Markdown
Contributor

Thanks for the PR, looks very exciting! Could you please consider the following?

GamepadJoyTransformKey includes "xbox_reverse" but the mapping object only has "default", "xbox", and "ps5". The non-null assertion gamepadJoyMappings[transformName]! crashes with a TypeError if this key is encountered — stopping all gamepad publishing, including any stop commands to a live robot. Fix: Add the missing entry or fall back to default:

const entry = gamepadJoyMappings[transformName] ?? gamepadJoyMappings["default"]!;

@XENONFFM
Copy link
Copy Markdown
Contributor Author

Sure I'll address this with the next release.
Out of curiosity, what AI/prompt did you use to get this review? 😁

@msadowski
Copy link
Copy Markdown
Contributor

Sure I'll address this with the next release. Out of curiosity, what AI/prompt did you use to get this review? 😁

I just asked Claude to review the code (in this case Sonnet 4.6), keeping the Foxglove app in mind

@defunctzombie defunctzombie merged commit 4e1f3bb into foxglove:main May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants