Update test matrix to include full MySQL 8 and MySQL 9 support #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
reviewed
May 27, 2025
Comment on lines
+79
to
+80
| // 3 warnings on MySQL 8+, 1 warning on legacy MySQL 5 | ||
| $this->assertGreaterThanOrEqual(1, $command->warningCount); |
There was a problem hiding this comment.
Not for this PR, but would it be worth it detecting the MySQL version and adjusting the number here based on that?
There was a problem hiding this comment.
Not opposed, but given the nature of this test, I don't think this has particularly high priority. PRs welcome I suppose 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the test matrix to include full MySQL 8 and MySQL 9 support. It only improves our tests and documentation to emphasize we officially support MySQL 8+ and other compatible projects, building on top of our recent MySQL protocol improvements.
Builds on top of #207 and #196
Refs #112