Skip to content

Conversation

@lhoestq
Copy link

@lhoestq lhoestq commented Oct 17, 2025

e.g. for paths like hf://datasets/google/svq/audio/utts_gu_in_clean.parquet which is inside the google/svq dataset

let me know if tests are needed, we can have an account for fsspec on HF for the CI to use

@ap--
Copy link
Collaborator

ap-- commented Oct 17, 2025

Thank you for contributing @lhoestq

let me know if tests are needed, we can have an account for fsspec on HF for the CI to use

That would be ideal. From experience there are usually some edge cases that need adjustments.
The name should probably be chosen so that it's clear the account is only used for tests. I assume there's no way to locally mock the hf hub api?

Cheers,
Andreas

@lhoestq
Copy link
Author

lhoestq commented Oct 17, 2025

I assume there's no way to locally mock the hf hub api?

Actually I can easily patch HfApi.repo_info and HfApi.list_repo_tree which are enough to test read-only features, would it be ok ?

@ap--
Copy link
Collaborator

ap-- commented Oct 17, 2025

Yes! If that's easy to do we could start with readonly tests.

@lhoestq
Copy link
Author

lhoestq commented Oct 27, 2025

I just added readonly tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants