Skip to content

Conversation

philprime
Copy link
Member

@philprime philprime commented Oct 23, 2025

Multiple scripts use the ci-utils.sh as dependencies but the file-filters.yml does not look for changes in transitive dependencies, therefore jobs are not triggered when the file is changed.

Adds the ci-utils.sh to all file filters with at least one script using it

#skip-changelog

Closes #6514

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@codecov
Copy link

codecov bot commented Oct 23, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4002 1 4001 28
View the top 2 failed test(s) by shortest run time
SentryTests.SentryFileManagerTests::testCreateDirectoryIfNotExists_pathTooLogError_shouldLogError
Stack Traces | 0s run time
.../SentryTests/Helper/SentryFileManagerTests.swift:1091 - XCTAssertEqual failed: ("3") is not equal to ("1")
iOS_SwiftUI_UITests.LaunchUITests::testCaptureErrorReturnsValidId
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:57 - Failed to get matching snapshot: No matches found for Elements matching predicate '"errorId" IN identifiers' from input {(

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.40 ms 1249.56 ms 27.17 ms
Size 23.75 KiB 1.01 MiB 1006.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
fb48c9a 1232.49 ms 1266.27 ms 33.78 ms
d72784d 1214.31 ms 1241.35 ms 27.04 ms
7af87c1 1229.31 ms 1253.84 ms 24.53 ms
029a804 1219.65 ms 1241.96 ms 22.30 ms
139db8b 1231.50 ms 1258.19 ms 26.69 ms
7f4bf81 1241.73 ms 1270.66 ms 28.93 ms
83bb978 1238.33 ms 1260.04 ms 21.71 ms
42cfd79 1222.13 ms 1244.23 ms 22.10 ms
aac24ac 1225.94 ms 1256.38 ms 30.45 ms

App size

Revision Plain With Sentry Diff
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
fb48c9a 23.75 KiB 1006.34 KiB 982.59 KiB
d72784d 23.75 KiB 988.01 KiB 964.27 KiB
7af87c1 23.75 KiB 933.34 KiB 909.59 KiB
029a804 23.75 KiB 928.11 KiB 904.36 KiB
139db8b 23.75 KiB 920.64 KiB 896.89 KiB
7f4bf81 23.75 KiB 919.70 KiB 895.95 KiB
83bb978 23.75 KiB 920.64 KiB 896.89 KiB
42cfd79 23.75 KiB 880.20 KiB 856.45 KiB
aac24ac 23.75 KiB 1019.17 KiB 995.42 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Add ci-utils.sh to file-filters.yml

2 participants