feat(feedback): Screenshot button #4714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krystof Woldrich <[email protected]>
This was referenced Apr 9, 2025
antonis
commented
Apr 14, 2025
| @@ -8,20 +8,23 @@ import { defaultScreenshotButtonConfiguration } from './defaults'; | |||
| import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles'; | |||
| import { getTheme } from './FeedbackWidget.theme'; | |||
| import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types'; | |||
| import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager'; | |||
There was a problem hiding this comment.
The cyclic dep failure is fixed in #4718
# Conflicts: # CHANGELOG.md # packages/core/src/js/feedback/FeedbackWidget.styles.ts # packages/core/src/js/feedback/FeedbackWidgetManager.tsx # packages/core/src/js/feedback/integration.ts # packages/core/test/feedback/FeedbackWidgetManager.test.tsx
| @@ -180,6 +180,11 @@ describe('ScreenshotButton', () => { | |||
| const takeScreenshotButtonAfterCapture = queryByText('Take a screenshot'); | |||
| expect(takeScreenshotButtonAfterCapture).toBeNull(); | |||
| }); | |||
|
|
|||
| await waitFor(() => { | |||
| const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot'); | |||
There was a problem hiding this comment.
L: Just fixed the name and double negation not null.
Suggested change
| const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot'); | |
| const removeScreenshotButtonAfterCapture = queryByText('Remove screenshot'); | |
| expect(removeScreenshotButtonAfterCapture).toBeTruthy(); |
There was a problem hiding this comment.
Good catch Krystof 🙇
Updated with 59597a4
krystofwoldrich
approved these changes
Apr 14, 2025
10 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Based on feat(feedback): Theming
PR Chain:
📜 Description
take screenshot buttonin the feedback widget that:screenshot buttonscreenshot buttonthat captures a screenshot and opens the feedback widget modal with the captured screenshot as attachmentcaptureScreenshot()function is only available on mobile. Support for web environment will be investigated on a separate PR.Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot(orimagePickerset)enableTakeScreenshot💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps