fix(aci): use singular preferred detector in workflow processing #105674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
commented
Jan 5, 2026
| try: | ||
| if issue_occurrence is None or evt.group.issue_type.detector_settings is None: | ||
| # if there are no detector settings, default to the error detector | ||
| if issue_occurrence is None or evt.group.issue_type == ErrorGroupType: |
Member
Author
There was a problem hiding this comment.
Removed checking detector settings here because we will fall back to issue stream detector in logic outside of this function
Member
Author
There was a problem hiding this comment.
Also because any detector that has not been created yet will have None for detector_settings by default
ceorourke
reviewed
Jan 5, 2026
| @override_options({"workflow_engine.exclude_issue_stream_detector": False}) | ||
| def test_multiple_detectors(self) -> None: | ||
| issue_stream_workflow, issue_stream_detector, _, _ = self.create_detector_and_workflow( | ||
| def test_multiple_detectors__preferred(self) -> None: |
Member
There was a problem hiding this comment.
Should we test that we're not getting back any metric detectors?
Member
Author
There was a problem hiding this comment.
We only get back the error detector as the preferred detector. The only other possible detector we get back would be the issue stream detector given that we only return 1 specific detector
kcons
requested changes
Jan 6, 2026
cathteng
force-pushed
the
cathy/aci/preferred-detector
branch
from
064ff81 to
c548a6f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
|
||
| from sentry.notifications.notification_action.utils import should_fire_workflow_actions | ||
| from sentry.workflow_engine.processors.detector import get_detector_from_event_data | ||
| from sentry.workflow_engine.processors.detector import get_specific_detector |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kcons
approved these changes
Jan 7, 2026
Contributor
|
PR reverted: d272a54 |
getsentry-bot
added a commit
that referenced
this pull request
Jan 7, 2026
…ing (#105674)" This reverts commit b0c413d. Co-authored-by: cathteng <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will not fire issue alert notifications for issue types that already have separate detectors (metric, crons, uptime), at least for the initial GA.
This means we should collect a singular detector and only fallback to the issue stream detector if no directly associated detector exists.