Allow using Device::create_texture_with_data correctly with mipmapped non-block aligned textures#7678
Closed
atlv24 wants to merge 2 commits intogfx-rs:trunkfrom
Closed
Allow using Device::create_texture_with_data correctly with mipmapped non-block aligned textures#7678atlv24 wants to merge 2 commits intogfx-rs:trunkfrom
Device::create_texture_with_data correctly with mipmapped non-block aligned textures#7678atlv24 wants to merge 2 commits intogfx-rs:trunkfrom
Conversation
…low using logical size in mip size computations
cwfitzgerald
changed the title
Device::create_texture_with_data correctly with mipmapped nPOT texturesDevice::create_texture_with_data correctly with mipmapped non-block aligned textures
Member
|
Per discussion in the attached issue, this PR is not correct, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7677
Bevy side of the fix: bevyengine/bevy#19129
Description
Implicitly expand size to blocksize in create_texture_with_data to allow using logical size in mip size computations
Testing
Patch into bevy repro of the issue and it works
Squash or Rebase?
Any
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.