wgpu-hal: Expose vulkan::PhysicalDeviceFeatures #7682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7681
Description
PhysicalDeviceFeatures
is currently accessible throughvulkan::Adapter::physical_device_features
which is a public function. This structure seems required to be able to tell what Vulkan device features wgpu needs so it would be nice if it was accessible externally as otherwise it's impossible to create a wgpuDevice
from Vulkan objects safely.Re-exporting the type is the workaround I used just to get what I was doing to succeed, alternatively the whole
adapter
module could be made public or glob re-exported, this would also exposePhysicalDeviceProperties
which appears to have the same issue.Testing
Call
Adapter::physical_device_features
, notice that you can't name this type due to it being private.Squash or Rebase?
Any
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.