Validate pipeline layout immediate_size and fix its calculation when there are multiple immediate variables#9711
Open
beicause wants to merge 5 commits into
Open
Conversation
immediate_size and fix its calculation when there are multiple immediate variables
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
#8556
Description
Current
size_for_moduleis incorrect, which doesn't consider multiple immediate variables. We should check the immediate size used by entry points.wgpu/naga/src/valid/immediates.rs
Line 58 in d21c0d0
Also the validation is missing. Per spec https://gpuweb.github.io/gpuweb/#abstract-opdef-validating-gpuprogrammablestage
Testing
I updated naga snapshots and added a new test in
wgpu-validation/immediates.rs, which fails on trunk branch but it is fixed in this PR:cargo nextest run --test wgpu-validation render_multi_immediates_with_all_immediates_set_succeedsSquash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.