Skip to content

diag(cts_runner): raise log level to info by default #9734

Open
ErichDonGubler wants to merge 1 commit into
gfx-rs:trunkfrom
erichdongubler-mozilla:erichdongubler-push-rnunrvlsvswu
Open

diag(cts_runner): raise log level to info by default #9734
ErichDonGubler wants to merge 1 commit into
gfx-rs:trunkfrom
erichdongubler-mozilla:erichdongubler-push-rnunrvlsvswu

Conversation

@ErichDonGubler

Copy link
Copy Markdown
Member

No description provided.

@ErichDonGubler ErichDonGubler added area: infrastructure Testing, building, coordinating issues area: tests Improvements or issues with our test suite area: cts Issues stemming from the WebGPU Conformance Test Suite kind: diagnostics Error message should be better labels Jun 24, 2026
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 24, 2026 16:16
@andyleiserson andyleiserson disabled auto-merge June 24, 2026 16:16
@andyleiserson

Copy link
Copy Markdown
Contributor

I'm not sure this is the right way to do this... won't this suppress INFO-level logs in cts_runner?

@ErichDonGubler

ErichDonGubler commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@andyleiserson: I'm not sure what you mean. cts_runner only uses env_logger::init right now, which only prints at error-level messages by default (see this playground). We should only be increasing the log level with a change like this.

Now that you mention it, it would be better to just fix our env_logger init. 😅 I hadn't fully mentally loaded the control flow here with the graph of components before your pushback.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-rnunrvlsvswu branch from abc6029 to a30d709 Compare June 25, 2026 09:13
@ErichDonGubler ErichDonGubler changed the title diag(xtask/cts): set RUST_LOG env. var. to warn diag(cts_runner): raise log level to info by default Jun 25, 2026
@cwfitzgerald

Copy link
Copy Markdown
Member

I think the CI failures are legit, it's getting thrown by the log message it seems

@andyleiserson

Copy link
Copy Markdown
Contributor

cts_runner only uses env_logger::init right now, which only prints at error-level messages by default

You're right, I was thinking of the INFO messages logged by the xtask, but they wouldn't be affected by this.

I think the CI failures are legit, it's getting thrown by the log message it seems

May be fixed by https://github.com/gfx-rs/wgpu/pull/9709/changes#diff-1cd4ad01cffde4d05952fd3b0450f2a5db3b9fbd2af913f707940db2efc8a5b6R683. (The message was there even before this PR, we just didn't see it because the logging wasn't enabled.)

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-rnunrvlsvswu branch 2 times, most recently from e700ad2 to 62d3e68 Compare June 26, 2026 14:36
@ErichDonGubler

ErichDonGubler commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@andyleiserson:

May be fixed by https://github.com/gfx-rs/wgpu/pull/9709/changes#diff-1cd4ad01cffde4d05952fd3b0450f2a5db3b9fbd2af913f707940db2efc8a5b6R683. (The message was there even before this PR, we just didn't see it because the logging wasn't enabled.)

I opted to set RUST_LOG to error on the cts_runner invocations in the broken snapshot tests with the latest force-push. Info-level log entries seem like something that aren't useful to snapshot, but I could be persuaded that setting it to warn and updating snapshots to include the Vulkan errors could make sense (as follow-up).

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-rnunrvlsvswu branch from 62d3e68 to fba2020 Compare June 26, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cts Issues stemming from the WebGPU Conformance Test Suite area: infrastructure Testing, building, coordinating issues area: tests Improvements or issues with our test suite kind: diagnostics Error message should be better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants