-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add configuration for proxy exclusions #22027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11.0/bugfixes
Are you sure you want to change the base?
Add configuration for proxy exclusions #22027
Conversation
|
Note: in order to test, update must be forced or entry in |
b061769 to
b7b1d6d
Compare
|
In addition to agent, we may add to the select:
All of them currently use directly proxy settings or pass by the callCurl function |
Webhooks also can be affected. To me GLPI Network includes marketplace, call to network api, GLPI version check and telemetry (I see no reason proxy would be enabled for one of those services and not the others). |
|
Sounds like "CAS" should also have been a client for exclusion, but it seems it just do not use proxy settings. |
As far as I know, CAS requests are made on browser side. |
OK, did not know. Perfect then :) |
b7b1d6d to
d1a76fe
Compare
|
I think I've added all possible cases now |
d1a76fe to
72420c5
Compare
I've added webhooks; even if it probably would require a finer setup (well, agents also). |
|
I cannot really add tests. I had in mind to check if proxy config is passed or not to Guzzle client, but the only way I see to do that is using the |
|
I'm not sure this is as flexible as some people will need it to be if different resources of the same type are on different networks. It may require IP range exclusions instead. |
|
The goal for the moment is just to fix some cases that already are present (this only concerns inventory Agents) - a full complete solution would require much more wxork. |
cf6f666 to
cb00773
Compare
AdrienClairembault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me, just some types (didn't test functionally tho) 👍
Co-authored-by: Adrien Clairembault <[email protected]>

PoC
Adds a configuration entry to choose elements that won't use the proxy:

Only "Agents" have been added for now, plugins can add their own.
Toolbox::getGuzzleClient()andToolbox::doCallCurl()are compatible.