fix(gnovm): persist function-local declared types referenced by saved values#5894
Closed
ltzmaxwell wants to merge 8 commits into
Closed
fix(gnovm): persist function-local declared types referenced by saved values#5894ltzmaxwell wants to merge 8 commits into
ltzmaxwell wants to merge 8 commits into
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
…refs in persisted values
…nly escape, closure-declared type, run-pkg guard
thehowl
reviewed
Jul 10, 2026
Comment on lines
+50
to
+52
| - **`SetType` at declaration time (`OpTypeDecl`)**: persists types whose | ||
| values never escape — store bloat and gas for dead types; also detaches the | ||
| write from the save path that defines what actually needs resolving. |
Member
There was a problem hiding this comment.
I think this approach is actually more sensible.
Other types may never end up being saved as values but we save them nonetheless. It just makes sense that the cost of storing a type is entirely at package init; not "on-demand". Also considering the fact that doing this on-demand has a hefty traversal cost we'd have to do; while if we just did this at preprocessing it wouldn't entail any further traversals.
Contributor
Author
|
working on an alternative. |
Contributor
Author
|
close in favor of #5935. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetType'd (only package-level types are, at addpkg), so persisting a value referencing one writes a danglingRefType; after a node restart every access panics withunexpected type with id ...— the realm state is permanently unreadable. Reproduces on master via interface-typed package vars and closure captures.localTypeSaverwalk insaveObjectpersists reachable function-local types beforeSetObject;copyTypeWithRefspreservesParentLocso the local type's TypeID survives the persist/reload round trip.debugAssert-gated invariant inSetObjectpanics at save time on any dangling function-local type ref, so a missed route fails loudly inside the rolled-back tx instead of committing unreadable state.zrealm_localtype*filetests guard the save side under-tags debugAssertand pin the on-the-wireRefTypeshape.gnovm/adr/pr5894_local_type_persist.md.