fix(gnovm): persist function-local declared types eagerly at addpkg (alt to save-time walk)#5935
Open
ltzmaxwell wants to merge 10 commits into
Open
fix(gnovm): persist function-local declared types eagerly at addpkg (alt to save-time walk)#5935ltzmaxwell wants to merge 10 commits into
ltzmaxwell wants to merge 10 commits into
Conversation
…refs in persisted values
…ealm/p-pkg/resave restart txtar
…nly escape, closure-declared type, run-pkg guard
…alt to save-time walk)
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveFuncLocalTypes(machine.go) makes oneTranscribepass over the fileset insaveNewPackageValuesAndTypesandSetTypes every non-alias function-localTypeDecl; the ~150-linelocalTypeSaverwalk in realm.go is deleted.SetObjectdebugAssert falls back to a raw backend key probe: addpkg-persisted types are absent from later txs' freshcacheTypes, so the invariant is "resolvable from the store", not "written this tx".zrealm_localtype*.gnofiletests,restart_local_type*.txtarnode restarts, vm gas tests.