Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhesion actuator dyntype #2145

Open
vaxenburg opened this issue Oct 16, 2024 · 5 comments
Open

Adhesion actuator dyntype #2145

vaxenburg opened this issue Oct 16, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@vaxenburg
Copy link
Contributor

vaxenburg commented Oct 16, 2024

The feature, motivation and pitch

Is there a good reason the dyntype of adhesion actuators can only be none? Can't we expose dyntype (along with dynprm) as another custom attribute of the adhesion actuators, like e.g. gain? For example, having a filter dynamics for adhesion could be quite useful (and realistic in some cases).

Alternatives

No response

Additional context

No response

@vaxenburg vaxenburg added the enhancement New feature or request label Oct 16, 2024
@yuvaltassa
Copy link
Collaborator

This is a reasonable ask, however this should be possible now by saving an adhesion actuator as and then adding a dyntype. Yes, this is not as elegant as , but should just work.

So unless you're saying that you tried this and it failed, this request is basically about nicer MJCF cosmetics.

If you tried it and it failed then that's a bug 🙂

@vaxenburg
Copy link
Contributor Author

For now, I do something like this, but it's not very nice:

adhesion_actuator.dclass.general.dyntype = 'filter'
adhesion_actuator.dclass.general.dynprm = (0.01,)

Yeah, this is not a bug report, just an enhancement request

@vaxenburg
Copy link
Contributor Author

@yuvaltassa is it me or is your comment missing a bit or two? What do you mean by "saving an adhesion actuator as"?

@yuvaltassa
Copy link
Collaborator

I mean that if you have an XML with <adhesion> and you save the XML then you get a <general>.

But the trick you're using with default classes is even better, if you have procedural code.

That said, your enhancement request is valid and would not be hard to add. There are two options really:

  1. Expose dyntype
  2. If we think only filters are useful, expose timeconst, like in <position>.

WDYT?

@vaxenburg
Copy link
Contributor Author

vaxenburg commented Oct 17, 2024

Thanks Yuval, that sounds good. For all I know, for the <adhesion> shortcut we don't need more than filterexact, so that'd be my vote probably -- that is, expose only timeconst. And if you want more, you do it with <general>. How about that?

@yuvaltassa yuvaltassa self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants