Allow run/pause toggling from passive UI and handle, closes #2481 #2493
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2481.
The actual behavior of paused simulation in passive viewers is up to the user. To work as intended, the user should check
handle.run
to choose betweenmj_step
andmj_forward
:When the simulation is paused, the user can apply direct qpos manipulation and pose perturbation in the simulator.
Several concerns:
The
Handle
class already has a methodis_running
to check if the simulation window is running or exited, while thesimulator
usesrun=1/0
to indicate run/pause. The naming would potentially cause confusion.(Off-topic) The following line does not quite make sense to me (and opposite to several other cases above and below). Should
!sim->is_passive_
besim->is_passive_
?mujoco/simulate/simulate.cc
Line 1620 in 14dc6fd