Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

jimmymadon · 2024-11-13T20:45:29Z

Summary

Addresses issue:

Improve rendering time of newly added "Setup CTA" SiWG notification #9568

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

…etup-CTA.

…w for multiple keys.

…tests.

…tation success notification.

github-actions · 2024-11-13T20:52:37Z

Build files for 2733f6f are ready:

Download development build
Download production build

github-actions · 2024-11-13T20:53:36Z

Size Change: +782 B (+0.04%)

Total Size: 1.88 MB

Filename	Size	Change
`./dist/assets/js/googlesitekit-activation-********************.js`	24 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	55 kB	+78 B (+0.14%)
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.6 kB	+2 B (+0.01%)
`./dist/assets/js/googlesitekit-api-********************.js`	10.1 kB	+2 B (+0.02%)
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	6.17 kB	+1 B (+0.02%)
`./dist/assets/js/googlesitekit-data-********************.js`	2.37 kB	-3 B (-0.13%)
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	20.5 kB	-10 B (-0.05%)
`./dist/assets/js/googlesitekit-datastore-ui-********************.js`	10.1 kB	+2 B (+0.02%)
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	27.3 kB	+4 B (+0.01%)
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	81.9 kB	+55 B (+0.07%)
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	161 kB	+96 B (+0.06%)
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	33.5 kB	+107 B (+0.32%)
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	117 kB	-95 B (-0.08%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	184 kB	+35 B (+0.02%)
`./dist/assets/js/googlesitekit-modules-********************.js`	22.2 kB	-5 B (-0.02%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.8 kB	+1 B (0%)
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	40.9 kB	+34 B (+0.08%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	64.9 kB	+7 B (+0.01%)
`./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js`	24.4 kB	+69 B (+0.28%)
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	32.2 kB	+22 B (+0.07%)
`./dist/assets/js/googlesitekit-notifications-********************.js`	22.9 kB	+107 B (+0.47%)
`./dist/assets/js/googlesitekit-settings-********************.js`	126 kB	+78 B (+0.06%)
`./dist/assets/js/googlesitekit-splash-********************.js`	69 kB	+88 B (+0.13%)
`./dist/assets/js/googlesitekit-user-input-********************.js`	43.8 kB	+64 B (+0.15%)
`./dist/assets/js/googlesitekit-vendor-********************.js`	322 kB	+1 B (0%)
`./dist/assets/js/googlesitekit-widgets-********************.js`	96.3 kB	+43 B (+0.04%)

ℹ️ View Unchanged

Filename	Size
`./dist/assets/css/googlesitekit-admin-css-********************.min.css`	60 kB
`./dist/assets/css/googlesitekit-adminbar-css-********************.min.css`	11.8 kB
`./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css`	846 B
`./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css`	8.2 kB
`./dist/assets/js/32-********************.js`	2.76 kB
`./dist/assets/js/33-********************.js`	2.25 kB
`./dist/assets/js/34-********************.js`	3.64 kB
`./dist/assets/js/35-********************.js`	935 B
`./dist/assets/js/36-********************.js`	893 B
`./dist/assets/js/37-********************.js`	1.61 kB
`./dist/assets/js/38-********************.js`	1.57 kB
`./dist/assets/js/39-********************.js`	1.61 kB
`./dist/assets/js/40-********************.js`	1.59 kB
`./dist/assets/js/41-********************.js`	1.83 kB
`./dist/assets/js/42-********************.js`	3.11 kB
`./dist/assets/js/analytics-advanced-tracking-********************.js`	901 B
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10.1 kB
`./dist/assets/js/googlesitekit-consent-mode-********************.js`	25.6 kB
`./dist/assets/js/googlesitekit-datastore-forms-********************.js`	8.97 kB
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.08 kB
`./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js`	646 B
`./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js`	624 B
`./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js`	630 B
`./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js`	712 B
`./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js`	675 B
`./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js`	634 B
`./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js`	657 B
`./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js`	633 B
`./dist/assets/js/googlesitekit-i18n-********************.js`	3.93 kB
`./dist/assets/js/googlesitekit-polyfills-********************.js`	377 B
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	62.6 kB
`./dist/assets/js/runtime-********************.js`	1.4 kB

_{compressed-size-action}

…etup-CTA.

zutigrm

Thanks @jimmymadon LGTM

Note for MR reviewer: VRT is failing for different component, present in develop, not related to this PR
E2E failing due to the flakiness

…etup-CTA.

jimmymadon added 15 commits November 11, 2024 14:04

Add an enum of notification group IDs.

a38448a

Set notificationGroupID when registering a notification.

b5c227e

Merge branch 'develop' into enhancement/9658-improve-rendering-time-s…

f727a5b

…etup-CTA.

Add the groupID to the getQueuedNotifications selector.

f35b006

Make the getQueuedNotifications default state an empty object to allo…

d86ece2

…w for multiple keys.

Add groupID support to the receiveQueuedNotifications action.

28e4ea0

Use the groupID as a key to store multiple queued notifications.

838a1bd

Use the groupID to create a unique queue of notifications.

fbbd131

Allow the Notifications component to render a unique group's queue.

f612081

Add the SiwG to a unique setup CTA notification group.

f2fa629

Render the queue of Setup CTA notifications on the Dashboard.

d1a641c

Fix removal of grouped queuedNotification on dismissal.

f0dee8f

Pass the default group when receiving queuedNotifications in tests.

93d2e73

Pass the groupID for all existing usage of getQueuedNotifications in …

7108a3a

…tests.

Invalidate resolution of the default queue to trigger audience segmen…

160e953

…tation success notification.

jimmymadon added 2 commits November 14, 2024 10:34

Test GA4AdSenseLinked notification dismissal.

a2c7f8b

Merge branch 'develop' into enhancement/9658-improve-rendering-time-s…

ff665a4

…etup-CTA.

zutigrm approved these changes Nov 14, 2024

View reviewed changes

jimmymadon added 2 commits November 14, 2024 17:32

Add an act() safeguard for flaky test.

c4ec522

Merge branch 'develop' into enhancement/9658-improve-rendering-time-s…

2733f6f

…etup-CTA.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

jimmymadon commented Nov 13, 2024 •

edited by zutigrm

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

zutigrm left a comment

Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

Are you sure you want to change the base?

Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

Conversation

jimmymadon commented Nov 13, 2024 • edited by zutigrm Loading

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

github-actions bot commented Nov 13, 2024 • edited Loading

github-actions bot commented Nov 13, 2024 • edited Loading

zutigrm left a comment

Choose a reason for hiding this comment

jimmymadon commented Nov 13, 2024 •

edited by zutigrm

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading