Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Enhancement/9568 Improve rendering time for SiwG Setup CTA #9684

wants to merge 19 commits into from
+193 −69

Commits on Nov 11, 2024

  1. Add an enum of notification group IDs.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a38448a View commit details
    Browse the repository at this point in the history

  2. Set notificationGroupID when registering a notification.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b5c227e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into enhancement/9658-improve-rendering-time-s… 

    …etup-CTA.
    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f727a5b View commit details
    Browse the repository at this point in the history

  4. Add the groupID to the getQueuedNotifications selector.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f35b006 View commit details
    Browse the repository at this point in the history

  5. Make the getQueuedNotifications default state an empty object to allo… 

    …w for multiple keys.
    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d86ece2 View commit details
    Browse the repository at this point in the history

  6. Add groupID support to the receiveQueuedNotifications action.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    28e4ea0 View commit details
    Browse the repository at this point in the history

  7. Use the groupID as a key to store multiple queued notifications.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    838a1bd View commit details
    Browse the repository at this point in the history

  8. Use the groupID to create a unique queue of notifications.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fbbd131 View commit details
    Browse the repository at this point in the history

  9. Allow the Notifications component to render a unique group's queue.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f612081 View commit details
    Browse the repository at this point in the history

  10. Add the SiwG to a unique setup CTA notification group.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f2fa629 View commit details
    Browse the repository at this point in the history

  11. Render the queue of Setup CTA notifications on the Dashboard.

    @jimmymadon
    jimmymadon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d1a641c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Fix removal of grouped queuedNotification on dismissal.

    @jimmymadon
    jimmymadon committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f0dee8f View commit details
    Browse the repository at this point in the history

  2. Pass the default group when receiving queuedNotifications in tests.

    @jimmymadon
    jimmymadon committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    93d2e73 View commit details
    Browse the repository at this point in the history

  3. Pass the groupID for all existing usage of getQueuedNotifications in … 

    …tests.
    @jimmymadon
    jimmymadon committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7108a3a View commit details
    Browse the repository at this point in the history

  4. Invalidate resolution of the default queue to trigger audience segmen… 

    …tation success notification.
    @jimmymadon
    jimmymadon committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    160e953 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Test GA4AdSenseLinked notification dismissal.

    @jimmymadon
    jimmymadon committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a2c7f8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into enhancement/9658-improve-rendering-time-s… 

    …etup-CTA.
    @jimmymadon
    jimmymadon committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ff665a4 View commit details
    Browse the repository at this point in the history

  3. Add an act() safeguard for flaky test.

    @jimmymadon
    jimmymadon committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c4ec522 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into enhancement/9658-improve-rendering-time-s… 

    …etup-CTA.
    @jimmymadon
    jimmymadon committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2733f6f View commit details
    Browse the repository at this point in the history