Conversation
Updates to expose type1 charstring evaluation and support testing: - adds a `CharstringContext` impl for `Type1Font` - adds `Type1Font::evaluate_charstring` - moves and exposes (gated by cfg(test)) some charstring test helpers - changes `charstring::evaluate` to call `finish` on the sink when complete and cleans up the associated logic elsewhere
for easier usage
dfrg
added a commit
that referenced
this pull request
Mar 13, 2026
Adds support for detecting and processing type1 fonts to fauntlet. Also adds a check for a few tests fonts to CI. Additionally makes the type1 support in read-fonts visible and fixes a few warnings that were missed due to the expect(unused) attribute. First commit contains an intentionally broken type1 scale factor in fauntlet to prove that the CI checks are working. Based on #1761 which must land first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to expose type1 charstring evaluation and support testing:
CharstringContextimpl forType1FontType1Font::evaluate_charstringcharstring::evaluateto callfinishon the sink when complete and cleans up the associated logic elsewhere