fix: don't assume a window when testing for k6

[waisbrot]

Why

window might be undefined (inside a chrome extension context, for example), in which case isK6BrowserSession crashes instead of just returning false.

What

Check for undefined before dereferencing window.

Links

fixes #1644

Checklist

• Tests added
• Changelog updated
• Documentation updated

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecapitano]

Good catch. Many thanks for the fix 🙏

[waisbrot]

I'm not sure how to write a test for this and IMO it doesn't need a documentation update. Please LMK if you'd like either of those added.

[codecapitano]

I'm not sure how to write a test for this and IMO it doesn't need a documentation update. Please LMK if you'd like either of those added.

Hey Nathaniel 👋

It doesn't need a doc update.

I think for testing you can look at this test case.
Maybe something like that but not adding the k6 object to global and asserting with expect(...).toThrow(error?) works?

Would be great to have the test but in this case i think we can be pragmatic so it's not mandatory.
Maybe you can try but if it would take to long in contrast to the value it adds let's skip it.

[waisbrot]

Thanks for the pointer. I took a quick look, but I'm not going to have time to work on tests for a while, I think. So let's say skip.

[eskirk]

great fix - thank you