Skip to content

fix: don't assume a window when testing for k6 #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

fix: don't assume a window when testing for k6 #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

- Fix (`@grafana/faro-web-sdk`): Fixed an issue where custom severity and custom trigger properties
were not being included in user action attributes (#1551)
- Fix (`@grafana/faro-web-sdk`): Fixed an error when `initializeFaro` is called without any window
object present (#1643)

## 2.0.0.beta-2

Expand Down
2 changes: 1 addition & 1 deletion packages/web-sdk/src/config/makeCoreConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function createDefaultMetas(browserConfig: BrowserConfig): MetaItem[] {
...(browserConfig.metas ?? []),
];

const isK6BrowserSession = isObject((window as any).k6);
const isK6BrowserSession = isObject((window as any)?.k6);
if (isK6BrowserSession) {
return [...initialMetas, k6Meta];
}
Expand Down
Loading