r/aws_ec2_image_block_public_access: Add `region` argument #45023

ewbankkit · 2025-11-10T19:46:21Z

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds the missing region argument.
Requires resource identity schema migration.

Relations

Closes #44249.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEC2ImageBlockPublicAccess_serial' PKG=ec2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_ec2_image_block_public_access-add-region 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ImageBlockPublicAccess_serial -timeout 360m -vet=off
2025/11/12 13:26:02 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/12 13:26:02 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2ImageBlockPublicAccess_serial
=== PAUSE TestAccEC2ImageBlockPublicAccess_serial
=== CONT  TestAccEC2ImageBlockPublicAccess_serial
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/basic
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity/basic
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResource
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResourceNoRefresh
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity/RegionOverride
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity/Upgrade
=== RUN   TestAccEC2ImageBlockPublicAccess_serial/Identity/UpgradeNoRefresh
--- PASS: TestAccEC2ImageBlockPublicAccess_serial (749.61s)
    --- PASS: TestAccEC2ImageBlockPublicAccess_serial/basic (37.65s)
    --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity (711.96s)
        --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/basic (19.59s)
        --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResource (142.38s)
        --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResourceNoRefresh (152.45s)
        --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/RegionOverride (19.22s)
        --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/Upgrade (207.20s)
        --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/UpgradeNoRefresh (171.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	755.382s

% make testacc TESTARGS='-run=TestAccSQSQueue_Identity_' PKG=sqs ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_ec2_image_block_public_access-add-region 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/sqs/... -v -count 1 -parallel 4  -run=TestAccSQSQueue_Identity_ -timeout 360m -vet=off
2025/11/12 12:07:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/12 12:07:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSQSQueue_Identity_Basic
=== PAUSE TestAccSQSQueue_Identity_Basic
=== RUN   TestAccSQSQueue_Identity_RegionOverride
=== PAUSE TestAccSQSQueue_Identity_RegionOverride
=== RUN   TestAccSQSQueue_Identity_ExistingResource
=== PAUSE TestAccSQSQueue_Identity_ExistingResource
=== RUN   TestAccSQSQueue_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccSQSQueue_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccSQSQueue_Identity_Upgrade
=== PAUSE TestAccSQSQueue_Identity_Upgrade
=== RUN   TestAccSQSQueue_Identity_Upgrade_NoRefresh
=== PAUSE TestAccSQSQueue_Identity_Upgrade_NoRefresh
=== CONT  TestAccSQSQueue_Identity_Basic
=== CONT  TestAccSQSQueue_Identity_ExistingResource_NoRefresh_NoChange
=== CONT  TestAccSQSQueue_Identity_Upgrade_NoRefresh
=== CONT  TestAccSQSQueue_Identity_RegionOverride
--- PASS: TestAccSQSQueue_Identity_Basic (55.72s)
=== CONT  TestAccSQSQueue_Identity_Upgrade
--- PASS: TestAccSQSQueue_Identity_RegionOverride (60.29s)
=== CONT  TestAccSQSQueue_Identity_ExistingResource
--- PASS: TestAccSQSQueue_Identity_ExistingResource_NoRefresh_NoChange (96.27s)
--- PASS: TestAccSQSQueue_Identity_Upgrade_NoRefresh (108.78s)
--- PASS: TestAccSQSQueue_Identity_Upgrade (85.31s)
--- PASS: TestAccSQSQueue_Identity_ExistingResource (93.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	159.397s

… resource is NOT global.

…late.

% make testacc TESTARGS='-run=TestAccEC2ImageBlockPublicAccess_serial' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-aws_ec2_image_block_public_access-add-region 🌿... TF_ACC=1 go1.24.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2ImageBlockPublicAccess_serial -timeout 360m -vet=off 2025/11/05 16:01:04 Creating Terraform AWS Provider (SDKv2-style)... 2025/11/05 16:01:04 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccEC2ImageBlockPublicAccess_serial === PAUSE TestAccEC2ImageBlockPublicAccess_serial === CONT TestAccEC2ImageBlockPublicAccess_serial === RUN TestAccEC2ImageBlockPublicAccess_serial/Identity === RUN TestAccEC2ImageBlockPublicAccess_serial/Identity/basic === RUN TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResource === RUN TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResourceNoRefresh === RUN TestAccEC2ImageBlockPublicAccess_serial/Identity/RegionOverride === RUN TestAccEC2ImageBlockPublicAccess_serial/basic --- PASS: TestAccEC2ImageBlockPublicAccess_serial (348.14s) --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity (310.41s) --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/basic (20.60s) --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResource (208.82s) --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResourceNoRefresh (61.67s) --- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/RegionOverride (19.32s) --- PASS: TestAccEC2ImageBlockPublicAccess_serial/basic (37.73s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 354.219s

github-actions · 2025-11-10T19:46:32Z

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
Please see our prioritization guide for additional information on how the maintainers handle prioritization.
Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

gdavison

Some nits, but otherwise looks good.

--- PASS: TestAccEC2ImageBlockPublicAccess_serial (358.77s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity (358.77s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/basic (26.66s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResource (98.08s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/ExistingResourceNoRefresh (68.07s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/RegionOverride (23.91s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/Upgrade (66.26s)
--- PASS: TestAccEC2ImageBlockPublicAccess_serial/Identity/UpgradeNoRefresh (75.79s)

internal/service/ec2/ec2_image_block_public_access_identity_test.go

internal/service/ec2/ec2_image_block_public_access.go

internal/generate/servicepackage/service_package_gen.go.gtpl

internal/service/ec2/service_package_gen.go

github-actions · 2025-11-13T13:36:14Z

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions · 2025-11-13T20:42:24Z

This functionality has been released in v6.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

ewbankkit added 12 commits November 5, 2025 11:03

r/aws_ec2_image_block_public_access: Remove '@region(global=true)' --…

c6c88ef

… resource is NOT global.

Run 'make gen'.

f7875dd

Documentation.

62d3ce0

Add ability to inject SDKv2 IdentityUpgraders.

7efb50f

r/aws_ec2_image_block_public_access: Dummy IdentityUpgrader.

00e9e33

Run 'make gen'.

b11daf8

'identityUpgraders' -> 'sdkV2IdentityUpgraders'.

79898ba

r/aws_ec2_image_block_public_access: Add Region to configuration temp…

e1187c2

…late.

r/aws_ec2_image_block_public_access: Ensure 'region' is documented.

81a06b4

TODOs that get the tests passing.

d57d136

Merge branch 'main' into f-aws_ec2_image_block_public_access-add-region

fa00b53

ewbankkit added 4 commits November 12, 2025 11:36

r/aws_ec2_image_block_public_access: Don't generate identity tests.

5290eba

Correct CHANGELOG entry file name.

1b609e9

Replace 'inttypes.VersionedIdentity' with additional OptFuncs.

987ffe4

Run 'make gen'.

86a1f63

ewbankkit added the resource-identity Pertains to resource identity. label Nov 12, 2025

ewbankkit added 2 commits November 12, 2025 12:25

r/aws_ec2_image_block_public_access: Call identity upgrade tests.

fc71df5

Fix 'testAccEC2ImageBlockPublicAccess_Identity_Upgrade_NoRefresh'.

bfa450f

ewbankkit marked this pull request as ready for review November 12, 2025 19:02

ewbankkit requested a review from a team as a code owner November 12, 2025 19:02

No need to import 'helper/schema'.

805a5d6

gdavison approved these changes Nov 12, 2025

View reviewed changes

ewbankkit merged commit 102c77c into main Nov 13, 2025
68 checks passed

ewbankkit deleted the f-aws_ec2_image_block_public_access-add-region branch November 13, 2025 13:36

github-actions bot added this to the v6.21.0 milestone Nov 13, 2025

ewbankkit mentioned this pull request Nov 13, 2025

Missing region argument for aws_ec2_image_block_public_access resource #44249

Closed

terraform-aws-provider bot pushed a commit that referenced this pull request Nov 13, 2025

Update CHANGELOG.md for #45023

e7dc1df

ewbankkit added a commit that referenced this pull request Nov 13, 2025

Apply code review comment #45023 (comment).

f14862e

ewbankkit added a commit that referenced this pull request Nov 13, 2025

Remove empty line -- #45023 (comment).

cd460d0

ewbankkit mentioned this pull request Nov 13, 2025

r/aws_ec2_serial_console_access: Add region argument #45064

Merged

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

r/aws_ec2_image_block_public_access: Add `region` argument #45023

r/aws_ec2_image_block_public_access: Add `region` argument #45023

ewbankkit commented Nov 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

gdavison left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

r/aws_ec2_image_block_public_access: Add region argument #45023

r/aws_ec2_image_block_public_access: Add region argument #45023

Conversation

ewbankkit commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rollback Plan

Changes to Security Controls

Description

Relations

Output from Acceptance Testing

Uh oh!

github-actions bot commented Nov 10, 2025

Community Guidelines

Voting for Prioritization

Pull Request Authors

Uh oh!

gdavison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

r/aws_ec2_image_block_public_access: Add `region` argument #45023

r/aws_ec2_image_block_public_access: Add `region` argument #45023

ewbankkit commented Nov 10, 2025 •

edited

Loading