Unify minimum/maximum error handlers with draft-04 compatibility#163
Unify minimum/maximum error handlers with draft-04 compatibility#163Padmashree06 wants to merge 2 commits intohyperjump-io:mainfrom
Conversation
jdesrosiers
left a comment
There was a problem hiding this comment.
The new error handlers look like the right idea, but there's a lot of cleanup that needs to be done everywhere else.
- You need to rebase your branch and resolve conflicts
- The old handlers need to be removed
- There's no need for new normalization handlers
- There should be no changes to
hyperjump-json-schema.test.js
|
Thank you for the feedback. Regarding the changes to |
89f1f76 to
2d7cd58
Compare
|
I have removed the individual handlers and their corresponding normalization handlers, reverted the changes made in Please review |
jdesrosiers
left a comment
There was a problem hiding this comment.
You still haven't removed the maximum and minimum handlers. And you're still using a combined normalization handler. Normalization handlers are never combined, only error handlers. That's why they are defined separately.
…rmalization handlers
2d7cd58 to
1ab56dd
Compare
|
Thank you for the feedback. |
Description
This PR introduces unified error handlers for:
minimum,exclusiveMinimumanddraft-04 minimummaximum,exclusiveMaximumanddraft-04 maximumThe handlers now select and report only the most restrictive constraint, producing a single validation error instead of multiple overlapping messages.
Additional Updates
index.jsto avoid overlap and can be removed if preferred.Tests
All tests pass locally.
Fixes
Issue: #135