feat(cosmogen): implement 3rd party generation root template#4737
Conversation
github-actions
Bot
added
component:ci
julienrbrt
changed the title
| // add third party modules to for the root template. | ||
| for _, modules := range g.thirdModules { | ||
| data.Modules = append(data.Modules, modules...) | ||
| } | ||
|
|
There was a problem hiding this comment.
same needs to be done on generate openapi
doesnt affect ts-client generation but it will be nice to polish everything
Pantani
left a comment
Pantani
left a comment
There was a problem hiding this comment.
ACK, but I didn't test the TS files.
The TS client generation can only be used if the user is logged into the Buf registry CLI; otherwise, it will reach the rate limit. We should verify if the buffer is logged in and prevent the user from using the command, instead displaying a warning message and panic later.
I am not logged in via buf and I have never encountered a rate limit. CI isn't encountering a rate limit anymore either since a while (#4303 (comment)). Are you sure you aren't rate limited by country or because you use a VPN? We already have a warning that explains we should log in if rate limited. |
* feat(cosmogen): implement 3rd party generation * cl * hardcode module path * simplify * updates * lint * feat: Filter protos to module being processed * put test protos in correct folder * remove todo --------- Co-authored-by: “Clockwork” <alex@clockwork.gr> (cherry picked from commit 842b3e9) # Conflicts: # ignite/pkg/cosmosbuf/buf.go # ignite/pkg/cosmosgen/generate_typescript_test.go
…#4737) (#4740) * feat(cosmogen): implement 3rd party generation root template (#4737) * feat(cosmogen): implement 3rd party generation * cl * hardcode module path * simplify * updates * lint * feat: Filter protos to module being processed * put test protos in correct folder * remove todo --------- Co-authored-by: “Clockwork” <alex@clockwork.gr> (cherry picked from commit 842b3e9) # Conflicts: # ignite/pkg/cosmosbuf/buf.go # ignite/pkg/cosmosgen/generate_typescript_test.go * updates * cl --------- Co-authored-by: julienrbrt <julien@rbrt.fr>
3 participants
Closes: #4690