[CI][BENCHMARK] Merge new metadata implementation + tweaks to benchmarks #17617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves numerous aspects on how the benchmarking results are visualized: - rewrites the way HTML charts are generated, using a library (Chart.js) that's both easier to use and more visually pleasing. The new HTML page also now decouples data from the HTML itself, leading to faster load times and the ability to fetch data from remote sources. - The markdown output now contains a failures section that lists all benchmarks that failed for a given run. This will be a helpful for developers during PR testing. - Benchmarks can now have description that's displayed on the page. - And many more minor improvements.
…to unify-benchmark-ci
This reverts commit f79bbbf.
... and add presets to more easily
…to unify-benchmark-ci
…to unify-benchmark-ci
On PRs based on main, the scripts location is "old" and not accesible. Pick location based on the dir existance. Step 'gather info' is in a 'weird' location, so solve it with 2 tries to execute the script.
Co-authored-by: Piotr Balcer <[email protected]>
EuphoricThinking
approved these changes
Mar 25, 2025
|
@intel/llvm-gatekeepers PR ready for merging, thanks! |
|
@intel/llvm-gatekeepers please merge |
|
there's a failing job, I may have saw a comment about this that it's a job to be removed so can be ignored? |
|
found the comment - #17562 (comment) - maybe this is something we can get removed |
Yeah... I'm not actually sure why that job still exists, I'll ask around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially merges changes introduced in #17229. Specifically, it merges changes related to:
--build-jobsand--redownload(to re-fetch the benchmarks)Note: I am relying on this PR having its commits squashed during merge (which should be the default behavior for intel/llvm)
I did not try to clean up the commit history. Most of these changes are by Piotr anyway, I wanted to make sure he was properly credited for the changes.
Updates for current splitting effort of #17229: #17545 (comment)