Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][BENCHMARK] Merge new metadata implementation + tweaks to benchmarks #17617

Merged
merged 89 commits into from
Mar 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
e6ca992
Move UR devops scripts to devops folder
ianayl Feb 27, 2025
3d42db2
Restrict number of cores used
ianayl Feb 28, 2025
fc70520
Merge branch 'sycl' of https://github.com/intel/llvm into unify-bench…
ianayl Mar 4, 2025
4f08dd6
Restore ur-benchmark*.yml
ianayl Mar 4, 2025
497dcce
[benchmarks] improve HTML and Markdown output
pbalcer Mar 5, 2025
3cbed5e
Test UR benchmarking suite
ianayl Mar 5, 2025
1936207
Merge branch 'unify-benchmark-ci' of https://github.com/intel/llvm in…
ianayl Mar 5, 2025
f79bbbf
Bump tolerance to 7%
ianayl Mar 5, 2025
ffc8139
Revert "Bump tolerance to 7%"
ianayl Mar 5, 2025
0a34e0d
[benchmarks] fix failing benchmarks, improve html output
pbalcer Mar 6, 2025
3f42420
[benchmarks] fix python formatting with black
pbalcer Mar 6, 2025
1c7b189
update driver version
pbalcer Mar 6, 2025
ad13e93
simplify preset implementation and fix normal preset
pbalcer Mar 6, 2025
68ed0c4
Add PVC and BMG as runners
ianayl Mar 6, 2025
18fff93
Merge branch 'unify-benchmark-ci' of https://github.com/intel/llvm in…
ianayl Mar 6, 2025
3a65b98
Install dependencies before running UR script
ianayl Mar 6, 2025
220121a
Use venv for python packages
ianayl Mar 6, 2025
37d361c
Install venv before using venv
ianayl Mar 6, 2025
07f1e10
[benchmarks] allow specifying custom results directories
pbalcer Mar 7, 2025
64cf79c
[benchmarks] sort runs by date for html output
pbalcer Mar 7, 2025
6c28d33
simplify presets, remove suites if all set
pbalcer Mar 10, 2025
e15b94f
[benchmarks] use python venv for scripts
pbalcer Mar 10, 2025
78fd037
Run apt with sudo
ianayl Mar 10, 2025
0ed1599
Merge branch 'unify-benchmark-ci' of https://github.com/intel/llvm in…
ianayl Mar 10, 2025
82b6e55
Ignore "missing" apt packages in workflow
ianayl Mar 10, 2025
162cba0
Change pip to install to user
ianayl Mar 10, 2025
848f741
Ignore system controlled python env
ianayl Mar 10, 2025
918604e
[CI] use realpaths when referring to SYCL
ianayl Mar 10, 2025
72d8730
[CI] use minimal preset when running benchmarks
ianayl Mar 10, 2025
066f5a6
[CI] Allow 2 bench scripts locations (#17394)
lukaszstolarczuk Mar 12, 2025
18e5291
add ulls compute benchmarks
pbalcer Mar 12, 2025
237750e
[CI][Benchmark] Decouple results from existing file structure, fetch …
ianayl Mar 11, 2025
ba1297f
[benchmark] Disabling UR test suites
ianayl Mar 12, 2025
cd6097f
update compute benchmarks and fix requirements
pbalcer Mar 13, 2025
c4e92c6
fix url updates
pbalcer Mar 13, 2025
ed8eecc
use timestamps in result file names
pbalcer Mar 13, 2025
130212d
add hostname to benchmark run
pbalcer Mar 13, 2025
a884df8
Merge branch 'sycl' of https://github.com/intel/llvm into unify-bench…
ianayl Mar 13, 2025
5323386
add SubmitGraph benchmark
pbalcer Mar 13, 2025
5bd1d56
Restore sycl-linux-run-tests benchmarking action
ianayl Mar 13, 2025
e9b1375
Restore old SYCL benchmarking CI
ianayl Mar 13, 2025
a3edf7a
Add benchmarking results to sycl-docs.yml
ianayl Mar 13, 2025
6620e4a
[CI] Bump compute bench (#17431)
lukaszstolarczuk Mar 13, 2025
f4a2e39
Initial implementation of unified benchmark workflow
ianayl Mar 13, 2025
5d3b0d9
Merge branch 'unify-benchmark-ci' of https://github.com/intel/llvm in…
ianayl Mar 13, 2025
38394bb
[CI] Use commit hash instead, fix issues with run
ianayl Mar 13, 2025
f232b93
add benchmark metadata
pbalcer Mar 14, 2025
30cd308
apply formatting
pbalcer Mar 14, 2025
5e0539a
fix multiple descriptions/notes
pbalcer Mar 14, 2025
137407a
fix benchmark descriptions
pbalcer Mar 14, 2025
e0f5ca6
fix remote html output
pbalcer Mar 14, 2025
1041db6
fix metadata collection with dry run
pbalcer Mar 14, 2025
fae04f4
cleanup compute bench, fix readme, use newer sycl-bench
pbalcer Mar 14, 2025
cfa4a9c
[CI] configure upload results
ianayl Mar 14, 2025
ca963e6
[CI] Change config to update during workflow run instead
ianayl Mar 14, 2025
45a02e1
[CI] Change save name depending on build
ianayl Mar 14, 2025
98f9d38
bump to 2024-2025
ianayl Mar 14, 2025
ef88ea0
[CI] Enforce commit hash to be string regardless
ianayl Mar 14, 2025
b7acba2
cleanup options in js scripts and fix ordering on bar charts
pbalcer Mar 18, 2025
e330a50
use day on x axis for timeseries
pbalcer Mar 18, 2025
cde744c
Merge branch 'sycl' of https://github.com/intel/llvm into unify-bench…
ianayl Mar 19, 2025
cae7049
[benchmarks] Undo merging in prior tests
ianayl Mar 19, 2025
6bff3d6
add an option to limit build parallelism
pbalcer Mar 20, 2025
3662b43
tiny tweaks for benchmark tags
pbalcer Mar 20, 2025
d2610c3
add support for benchmark tags
pbalcer Mar 20, 2025
ffc60bf
support for tags in html
pbalcer Mar 20, 2025
75dd229
better and more tags
pbalcer Mar 20, 2025
cec8f05
formatting
pbalcer Mar 20, 2025
a0d8370
fix fetching tags from remote json
pbalcer Mar 20, 2025
c7f8d10
fix results /w descriptions and add url/commit of benchmarks
pbalcer Mar 20, 2025
1dad513
fix git repo/hash for benchmarks
pbalcer Mar 20, 2025
8437b89
Merge branch 'sycl' of https://github.com/intel/llvm into unify-bench…
ianayl Mar 21, 2025
2dbf350
Revert changes to workflow files
ianayl Mar 21, 2025
a4a9907
Revert changes to composite actions
ianayl Mar 21, 2025
bdef08b
Revert changes to get_system_info.sh
ianayl Mar 21, 2025
9e51c86
Revert changes not related to metadata
ianayl Mar 22, 2025
6fa722b
Merge branch 'sycl' of https://github.com/intel/llvm into benchmark-m…
ianayl Mar 22, 2025
5cc02c5
Revert changes to html
ianayl Mar 22, 2025
b49ff88
Revert presets.py
ianayl Mar 22, 2025
9357df2
Revert benchmark.yml
ianayl Mar 22, 2025
115dd5e
Merge branch 'benchmark-metadata' of https://github.com/ianayl/sycl i…
ianayl Mar 24, 2025
03bfd15
Update imports to reflect result.py move
ianayl Mar 24, 2025
0ff0142
Add benchmark history updates
ianayl Mar 24, 2025
1ef9251
Correct bad conflict resolution over cudnn/cublas flags
ianayl Mar 25, 2025
31c6695
Remove use of typing to stay consistent across files
ianayl Mar 25, 2025
136f64e
Remove debug comments
ianayl Mar 25, 2025
ccb2a9c
Remove trailing spaces
ianayl Mar 25, 2025
f8ccc30
Specify that git metadata is modifiable
ianayl Mar 25, 2025
c54cd76
Remove unused metadata variable for now
ianayl Mar 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 64 additions & 10 deletions devops/scripts/benchmarks/benches/base.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,37 @@
# Copyright (C) 2024 Intel Corporation
# Copyright (C) 2024-2025 Intel Corporation
# Part of the Unified-Runtime Project, under the Apache License v2.0 with LLVM Exceptions.
# See LICENSE.TXT
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

from dataclasses import dataclass
import os
import shutil
from pathlib import Path
from .result import Result
from utils.result import BenchmarkMetadata, BenchmarkTag, Result
from options import options
from utils.utils import download, run
import urllib.request
import tarfile

benchmark_tags = [
BenchmarkTag("SYCL", "Benchmark uses SYCL runtime"),
BenchmarkTag("UR", "Benchmark uses Unified Runtime API"),
BenchmarkTag("L0", "Benchmark uses Level Zero API directly"),
BenchmarkTag("UMF", "Benchmark uses Unified Memory Framework directly"),
BenchmarkTag("micro", "Microbenchmark focusing on a specific functionality"),
BenchmarkTag("application", "Real application-based performance test"),
BenchmarkTag("proxy", "Benchmark that simulates real application use-cases"),
BenchmarkTag("submit", "Tests kernel submission performance"),
BenchmarkTag("math", "Tests math computation performance"),
BenchmarkTag("memory", "Tests memory transfer or bandwidth performance"),
BenchmarkTag("allocation", "Tests memory allocation performance"),
BenchmarkTag("graph", "Tests graph-based execution performance"),
BenchmarkTag("latency", "Measures operation latency"),
BenchmarkTag("throughput", "Measures operation throughput"),
BenchmarkTag("inference", "Tests ML/AI inference performance"),
BenchmarkTag("image", "Image processing benchmark"),
BenchmarkTag("simulation", "Physics or scientific simulation benchmark"),
]

benchmark_tags_dict = {tag.name: tag for tag in benchmark_tags}


class Benchmark:
Expand Down Expand Up @@ -55,19 +76,25 @@ def create_data_path(self, name, skip_data_dir=False):
data_path = os.path.join(self.directory, name)
else:
data_path = os.path.join(self.directory, "data", name)
if options.rebuild and Path(data_path).exists():
if options.redownload and Path(data_path).exists():
shutil.rmtree(data_path)

Path(data_path).mkdir(parents=True, exist_ok=True)

return data_path

def download(self, name, url, file, untar=False, unzip=False, skip_data_dir=False):
def download(
self,
name,
url,
file,
untar=False,
unzip=False,
skip_data_dir=False,
checksum="",
):
self.data_path = self.create_data_path(name, skip_data_dir)
return download(self.data_path, url, file, untar, unzip)

def name(self):
raise NotImplementedError()
return download(self.data_path, url, file, untar, unzip, checksum)

def lower_is_better(self):
return True
Expand All @@ -87,6 +114,30 @@ def stddev_threshold(self):
def get_suite_name(self) -> str:
return self.suite.name()

def name(self):
raise NotImplementedError()

def description(self):
return ""

def notes(self) -> str:
return None

def unstable(self) -> str:
return None

def get_tags(self) -> list[str]:
return []

def get_metadata(self) -> BenchmarkMetadata:
return BenchmarkMetadata(
type="benchmark",
description=self.description(),
notes=self.notes(),
unstable=self.unstable(),
tags=self.get_tags(),
)


class Suite:
def benchmarks(self) -> list[Benchmark]:
Expand All @@ -97,3 +148,6 @@ def name(self) -> str:

def setup(self):
return

def additionalMetadata(self) -> dict[str, BenchmarkMetadata]:
return {}
Loading
Loading